Add non-const overload for Root::Model() getter #1524
Merged
+28
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with the getters for World which also overload on const-ness. Co-authored-by: Sean Curtis <[email protected]> Signed-off-by: Jeremy Nimmer <[email protected]>
jwnimmer-tri
force-pushed
the
model-get-mutable
branch
from
c1e3569 to
0e227a6
Compare
scpeters
reviewed
Jan 2, 2025
python/src/sdf/pyRoot.cc
Outdated
| @@ -83,7 +83,7 @@ void defineRoot(pybind11::object module) | |||
| "Get a world based on an index.") | |||
| .def("world_name_exists", &sdf::Root::WorldNameExists, | |||
| "Get whether a world name exists.") | |||
| .def("model", &sdf::Root::Model, | |||
| .def("model", pybind11::overload_cast<sdf::Model *>(&sdf::Root::Model), | |||
There was a problem hiding this comment.
there are build failures related to this line. In the binding for World::PhysicsByIndex, the template argument to pybind11::overload_cast is uint64_t, which matches the input argument to that function not its return type. Maybe try reverting this line?
There was a problem hiding this comment.
Thanks! I added the overload_cast because it has a (different) compilation error without it, but indeed I spelled it wrong. I pushed a tweak that fixes the build now (just remove the template argument).
Signed-off-by: Jeremy Nimmer <[email protected]>
jwnimmer-tri
force-pushed
the
model-get-mutable
branch
from
4fdb5ee to
049a36f
Compare
ahcorde
approved these changes
Jan 6, 2025
scpeters
reviewed
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes (N/A).
Summary
Adds a non-const overload for
Root::Model()getter. This is consistent with the getters forWorldwhich also overload on const-ness.Test it
There are automated unit tests. Manual testing is unnecessary.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.