Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename settings memory, timeout, nominatim_endpoint, overpass_endpoint #1136

Merged
merged 8 commits into from
Mar 2, 2024

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Feb 27, 2024

This PR renames some settings module settings for better clarity in v2. These renamed settings have been deprecated for v1 release in #1138.

  • settings.memory -> settings.overpass_memory
  • settings.timeout -> settings.requests_timeout
  • settings.nominatim_endpoint -> settings.nominatim_url
  • settings.overpass_endpoint -> settings.overpass_url

Builds on #1129. See also #1106.

@gboeing gboeing changed the base branch from xml to v2 February 27, 2024 03:57
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (a16fdf6) to head (f592322).

❗ Current head f592322 differs from pull request most recent head 7ce19f4. Consider uploading reports for the commit 7ce19f4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              xml    #1136   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          25       25           
  Lines        2422     2422           
=======================================
  Hits         2376     2376           
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing changed the base branch from v2 to xml February 27, 2024 04:37
@gboeing gboeing mentioned this pull request Feb 28, 2024
13 tasks
@gboeing gboeing changed the title Rename settings.memory and settings.timeout Rename settings memory, timeout, nominatim_endpoint, overpass_endpoint Mar 1, 2024
Base automatically changed from xml to v2 March 2, 2024 05:21
@gboeing gboeing merged commit f9ae68b into v2 Mar 2, 2024
1 check passed
@gboeing gboeing deleted the settings branch March 2, 2024 05:22
@gboeing
Copy link
Owner Author

gboeing commented May 3, 2024

The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant