-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plot_orientation: support directed graph bearings #1139
Conversation
b5c56a0
to
ee3d63d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looking good. Just a few comments.
07613cc
to
a0a86dc
Compare
a0a86dc
to
32ed03f
Compare
@gboeing looks like I need another workflow approval. If the test passes then this PR is good on my end absent any additional suggestions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #1139 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 25 25
Lines 2428 2433 +5
=======================================
+ Hits 2380 2385 +5
Misses 48 48 ☔ View full report in Codecov by Sentry. |
The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details. |
closes #1137
for v2 / #1106
TODOs:
orientation_entropy