Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.12.2 #51

Open
wants to merge 100 commits into
base: mc1.10
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
a7a84fd
1.12
Dockter Jun 24, 2017
7c2f21a
Update configuration files to 1.12.1
Dockter Sep 18, 2017
d5229e2
Initial update to 1.12.1. Still needs registry updates among other t…
Dockter Sep 18, 2017
e6129c1
work
Sep 18, 2017
bd3b6cf
Merge pull request #1 from kashike/1.12.1.fork
Dockter Sep 18, 2017
00227b5
Small repairs.
Dockter Sep 18, 2017
56a030d
Fix block/item registries.
Dockter Sep 18, 2017
153f024
Fix sound registry.
Dockter Sep 18, 2017
0d4f6eb
Fix Item lookup.
Dockter Sep 18, 2017
f8fe817
Progress.
Dockter Sep 18, 2017
0e532e0
Fix some additional registry issues and naming of models and textures.
Dockter Sep 19, 2017
7b9684b
Fix model renders.
Dockter Sep 19, 2017
1a32eff
Fix Sponge Compatibility.
Dockter Sep 19, 2017
d36e26b
Fix netty sending packet on different thread. Fixes sponge compatibi…
Dockter Sep 19, 2017
36e24a4
Turn off debugging.
Dockter Sep 19, 2017
c54f807
Revert this change. Fix was incomplete.
Dockter Sep 19, 2017
ec1519f
Fix recipe registrations.
Dockter Sep 22, 2017
fc6df33
Fix ModId naming convention.
Dockter Sep 27, 2017
c8b022d
Fix recipe typo's.
Dockter Sep 27, 2017
8a6c4ba
Resolve conflict with JEI/NEI.
Dockter Oct 3, 2017
eee529b
Add inital gitignore
rolandoislas Oct 26, 2017
842c3ff
Merge pull request #2 from rolandoislas/pr/integration-bug-fix
Dockter Oct 27, 2017
f0140eb
Update version to 1.12.2
Dockter Oct 27, 2017
b3828f9
Merge branch '1.12.1' of https://github.com/AlmuraDev/SGCraft into 1.…
Dockter Oct 27, 2017
52560ae
Fix FeatureGeneration for 1.12.2
Dockter Nov 28, 2017
589a993
More debugging when your chasing issues with Forge, Sponge and Terrai…
Dockter Nov 29, 2017
a7a1dd1
Fixes missing backgrounds and item tooltips
Thutmose Jan 3, 2018
dc9cdf8
Merge pull request #3 from Thutmose/1.12.2
Dockter Jan 7, 2018
be544d3
DHD orange button glint fix
Radviger Feb 12, 2018
a4b3239
Small DHD GUI improvement. New button pressing sounds.
Radviger Feb 12, 2018
df698d1
Updated forge & deps.
Radviger Feb 12, 2018
d54447d
Fixed item models.
Radviger Feb 12, 2018
39222c4
Error messages are now translatable. Added russian translation.
Radviger Feb 12, 2018
9a9eaab
Merge pull request #5 from Radviger/1.12.2
Dockter Feb 25, 2018
410e1eb
Fix missing files.
Dockter Feb 25, 2018
64794bc
Fix path of the gradle jar.
Dockter Feb 25, 2018
b7ace21
Fixed item models
Radviger May 19, 2018
7aea2c5
Glowing event horizon
Radviger May 19, 2018
812998e
Merge pull request #12 from Radviger/1.12.2
Dockter May 23, 2018
dba790f
Added smoother game ring animation. Enhanced sounds for iris & ring r…
Radviger Jul 13, 2018
9ca2ce9
Fixed chevron symbols semi-opaque background.
Radviger Jul 13, 2018
d5186a8
Converted ru_RU.lang to UTF-8
Radviger Jul 14, 2018
3a2e3da
Merge pull request #13 from Radviger/1.12.2
Dockter Jul 16, 2018
b3ed9e5
Fix iris always being detected as closed.
Dockter Jul 16, 2018
ee1cc88
Fixed iris thought to be always closed
Radviger Jul 16, 2018
99f130c
Immediate stargate dialling using DHD.
Radviger Aug 4, 2018
d166f32
Merge branch '1.12.2' of https://github.com/Radviger/SGCraft into 1.12.2
Dockter Aug 7, 2018
6537e26
Update gradle to match other projects.
Dockter Aug 7, 2018
7077148
Experiment with putting the immediate dial ability on the DHD TE inst…
Dockter Aug 8, 2018
e06a5f5
Fix DHD not disconnecting when sending empty address in server bound …
Dockter Aug 8, 2018
3b814ef
Bring forward fixes for floating stargate and the generation bug.
Dockter Aug 8, 2018
53a8a93
Create readme.md
Dockter Aug 8, 2018
cba9a8b
Fixed RF PowerUnit client crash.
Radviger Aug 10, 2018
0415d67
Update mcmod.info
Dockter Aug 10, 2018
b368ae6
Merge pull request #20 from Radviger/1.12.2
Dockter Aug 10, 2018
a8f015f
Merge branch '1.12.2' of https://github.com/AlmuraDev/SGCraft into 1.…
Dockter Aug 10, 2018
2d2458c
Update gradle versioning.
Dockter Aug 10, 2018
ae00429
Merge pull request #1 from AlmuraDev/1.12.2
Radviger Aug 10, 2018
f1aabb3
Update readme.md
Dockter Aug 10, 2018
14bdb9f
Fix dimension map lookup.
Dockter Aug 10, 2018
bf02134
Merge branch '1.12.2' of https://github.com/AlmuraDev/SGCraft into 1.…
Dockter Aug 10, 2018
6e46dff
Fix PowerScreen.
Dockter Aug 11, 2018
cb4e5af
Implement / Fix:
Dockter Aug 13, 2018
db380f7
Update readme.md
Dockter Aug 13, 2018
5fc15c0
Fix chunk loading issue across dimensions.
Dockter Aug 13, 2018
a592c79
Merge branch '1.12.2' of https://github.com/AlmuraDev/SGCraft into 1.…
Dockter Aug 13, 2018
bd44869
Fix Stargate opening sound and timings.
Dockter Aug 13, 2018
c88bf34
Implement:
Dockter Aug 13, 2018
33cdafa
Version Bump.
Dockter Aug 13, 2018
e05ac1d
Cleanup.
Dockter Aug 14, 2018
8faef8f
Fix this for the last time.
Dockter Aug 14, 2018
2521b0f
Add the ability to configure power values for IC2 and RF.
Dockter Aug 15, 2018
7a25b4c
Merge branch '1.12.2' of https://github.com/AlmuraDev/SGCraft into 1.…
Dockter Aug 15, 2018
728cc0e
Bump for release.
Dockter Aug 15, 2018
364c678
Fix config sync issue between server/client with IC2PowerTE and RFPow…
Dockter Aug 15, 2018
51dc4b0
Bump version.
Dockter Aug 15, 2018
2c8b31a
Fix some incorrect assumptions I made regarding TE's.
Dockter Aug 16, 2018
becbeea
I missed this while fixing TE's.
Dockter Aug 16, 2018
4955dbc
Never copy paste.
Dockter Aug 16, 2018
d75c8c0
Fix the SGBaseTE not setting the address when the baseBlock is the la…
Dockter Aug 17, 2018
aea5856
Merge branch '1.12.2' of https://github.com/AlmuraDev/SGCraft into 1.…
Dockter Aug 17, 2018
1f4dd4a
Implement:
Dockter Aug 17, 2018
40c8c2d
Re-Format how I have the display power values on DHDFuelScreen.
Dockter Aug 17, 2018
91167eb
Fix the DHD so it doesn't have to face the gate to create a link.
Dockter Aug 17, 2018
661ef9d
Added Support for Simplified Chinese language
kuriyamatokisaki Aug 19, 2018
be968c9
Fix RF Bug?
Dockter Sep 6, 2018
34a8a37
Added event horizon sound loop
Radviger Dec 4, 2018
3bbc94a
Fixed bug with infinite event horizon sound loop & missing iris hit s…
Radviger Dec 5, 2018
576ac35
Added entity teleportation sound
Radviger Dec 6, 2018
c5ed0e7
Fixed infinite event horizon/gate dialling sound loop after client-si…
Radviger Dec 8, 2018
ba8d620
Merge branch '1.12.2' into 1.12.2
Radviger Dec 8, 2018
a2a6f9f
Merge pull request #40 from Radviger/1.12.2
Dockter Jan 9, 2019
f40dd04
Bump Forge & SRG Mappings.
Dockter Jan 9, 2019
40805fd
@Radviger this should not have been removed from this commit: https:…
Dockter Jan 9, 2019
1df977f
Fix ComputerCraft interfaces. @Radviger, Char != String. The CCInt…
Dockter Feb 14, 2019
f55c0a3
Fix teleport sound not playing when exiting event horizon.
Dockter Feb 14, 2019
23fb506
Merge pull request #27 from f0rb1d/1.12.2
Dockter Feb 14, 2019
cc8281a
Bump version for release.
Dockter Feb 14, 2019
d7d7d46
Merge branch '1.12.2' of https://github.com/AlmuraDev/SGCraft into 1.…
Dockter Feb 14, 2019
8e01a06
Removed the mixin entry, its not needed
Dockter Apr 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
.gradle/
.idea/
*.iml
lib/*
!lib/README.txt
build/
classes/
run/
52 changes: 33 additions & 19 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,31 +1,49 @@
buildscript {
repositories {
mavenCentral()
mavenLocal()
jcenter()
maven { url = "http://files.minecraftforge.net/maven" }
maven {
url = "http://files.minecraftforge.net/maven"
}
maven {
url = "https://oss.sonatype.org/content/repositories/snapshots/"
}
}
dependencies {
classpath 'net.minecraftforge.gradle:ForgeGradle:2.2-SNAPSHOT'
classpath 'net.minecraftforge.gradle:ForgeGradle:2.3-SNAPSHOT'
}
}
apply plugin: 'net.minecraftforge.gradle.forge'
//Only edit below this line, the above code adds and enables the nessasary things for Forge to be setup.

apply plugin: 'net.minecraftforge.gradle.forge'

//version = "1.0"
//group= "com.yourname.modid" // http://maven.apache.org/guides/mini/guide-naming-conventions.html
archivesBaseName = jarName

repositories {
maven { url = "http://maven.cil.li/" }
maven {
name = 'oss-sonatype-public'
url = 'https://oss.sonatype.org/content/groups/public/'
}
maven { url = "http://maven.ic2.player.to" }
maven { url = "http://repo.spongepowered.org/maven" }
maven { url = "http://cc.crzd.me/maven/" }
}

dependencies {
compile "li.cil.oc:OpenComputers:MC1.12.1-1.7.1.52"
compile "net.industrial-craft:industrialcraft-2:2.8.93-ex112:api"
deobfCompile "dan200.computercraft:ComputerCraft:1.80pr1-build4"
}

deobfMcMCP { failOnAtError = false }
deobfMcSRG { failOnAtError = false }

minecraft {
version = "1.10.2-12.18.2.2099"
version = "1.12.2-14.23.5.2768"
runDir = "run"

// the mappings can be changed at any time, and must be in the following format.
// snapshot_YYYYMMDD snapshot are built nightly.
// stable_# stables are built at the discretion of the MCP team.
// Use non-default mappings at your own risk. they may not allways work.
// simply re-run your setup task after changing the mappings to update your workspace.
mappings = "snapshot_20160518"
// makeObfSourceJar = false // an Srg named sources jar is made by default. uncomment this to disable.
mappings = 'snapshot_20180808'
useDepAts = true
}

sourceSets.main {
Expand All @@ -34,10 +52,6 @@ sourceSets.main {
resources.srcDirs "src/resources"
}

//jar {
// exclude "ic2"
//}

processResources {

// this will ensure that this task is redone when the versions change.
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version = 1.13.2-mc1.10.2
mcversion = [1.10.2,1.10.2]
version = 1.15.8-forge-release
mcversion = [1.12.2,1.12.2]
group = gcewing.sg
jarName = SGCraft
Binary file added gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Mon Sep 14 12:28:28 PDT 2015
#Fri Sep 30 11:48:54 CEST 2016
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-2.7-bin.zip
distributionUrl=http\://services.gradle.org/distributions/gradle-3.5-all.zip
90 changes: 90 additions & 0 deletions gradlew.bat
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
@if "%DEBUG%" == "" @echo off
@rem ##########################################################################
@rem
@rem Gradle startup script for Windows
@rem
@rem ##########################################################################

@rem Set local scope for the variables with windows NT shell
if "%OS%"=="Windows_NT" setlocal

@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
set DEFAULT_JVM_OPTS=

set DIRNAME=%~dp0
if "%DIRNAME%" == "" set DIRNAME=.
set APP_BASE_NAME=%~n0
set APP_HOME=%DIRNAME%

@rem Find java.exe
if defined JAVA_HOME goto findJavaFromJavaHome

set JAVA_EXE=java.exe
%JAVA_EXE% -version >NUL 2>&1
if "%ERRORLEVEL%" == "0" goto init

echo.
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
echo.
echo Please set the JAVA_HOME variable in your environment to match the
echo location of your Java installation.

goto fail

:findJavaFromJavaHome
set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE=%JAVA_HOME%/bin/java.exe

if exist "%JAVA_EXE%" goto init

echo.
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
echo.
echo Please set the JAVA_HOME variable in your environment to match the
echo location of your Java installation.

goto fail

:init
@rem Get command-line arguments, handling Windowz variants

if not "%OS%" == "Windows_NT" goto win9xME_args
if "%@eval[2+2]" == "4" goto 4NT_args

:win9xME_args
@rem Slurp the command line arguments.
set CMD_LINE_ARGS=
set _SKIP=2

:win9xME_args_slurp
if "x%~1" == "x" goto execute

set CMD_LINE_ARGS=%*
goto execute

:4NT_args
@rem Get arguments from the 4NT Shell from JP Software
set CMD_LINE_ARGS=%$

:execute
@rem Setup the command line

set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar

@rem Execute Gradle
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%

:end
@rem End local scope for the variables with windows NT shell
if "%ERRORLEVEL%"=="0" goto mainEnd

:fail
rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
rem the _cmd.exe /c_ return code!
if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1
exit /b 1

:mainEnd
if "%OS%"=="Windows_NT" endlocal

:omega
16 changes: 16 additions & 0 deletions readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
This repo contains several continuations of the original SGCraft mod developed by gcewing.

Downloads are available here: https://ore.spongepowered.org/Dockter/SGCraft

The following branches are active:
- 1.12.2 -> Active fixes for 1.12.2
- api-7 -> All fixes from 1.12.2 branch plus Sponge permissions checks and event firings.
- feature/zpm -> Everything from api-7 + a custom zpm module implementation specifically designed for usage with IC2 and the Almura mod.

feature/zpm branch, use this:
- vm options: -Xincgc -Xms1024M -Xmx2048M -Dfml.coreMods.load=org.spongepowered.mod.SpongeCoremod
- program arguments: --noCoreSearch

Any questions please create an issue.

Thanks.
10 changes: 5 additions & 5 deletions src/base/gcewing/sg/BaseAORenderingManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
import net.minecraft.client.renderer.BlockModelShapes;
import net.minecraft.client.renderer.BlockModelRenderer;
import net.minecraft.client.renderer.BlockRendererDispatcher;
import net.minecraft.client.renderer.BufferBuilder;
import net.minecraft.client.renderer.Tessellator;
import net.minecraft.client.renderer.texture.TextureAtlasSprite;
import net.minecraft.client.renderer.VertexBuffer;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
Expand Down Expand Up @@ -66,26 +66,26 @@ public void renderBlockDamage(IBlockState state, BlockPos pos, TextureAtlasSprit
Trans3 t = Trans3.blockCenter;
Block block = state.getBlock();
for (BlockRenderLayer layer : BlockRenderLayer.values())
if (block.canRenderInLayer(layer))
if (block.canRenderInLayer(state,layer))
rend.renderBlock(world, pos, state, target, layer, t);
IBakedModel model = target.getBakedModel();
VertexBuffer tess = Tessellator.getInstance().getBuffer();
BufferBuilder tess = Tessellator.getInstance().getBuffer();
getBlockModelRenderer().renderModel(world, model, state, pos, tess, false); //TODO chould checkSides be false?
}
else
base.renderBlockDamage(state, pos, icon, world);
}

@Override
public boolean renderBlock(IBlockState state, BlockPos pos, IBlockAccess world, VertexBuffer tess) {
public boolean renderBlock(IBlockState state, BlockPos pos, IBlockAccess world, BufferBuilder tess) {
ICustomRenderer rend = getCustomRenderer(world, pos, state);
if (rend != null)
return customRenderBlockToWorld(world, pos, state, tess, null, rend);
else
return base.renderBlock(state, pos, world, tess);
}

protected boolean customRenderBlockToWorld(IBlockAccess world, BlockPos pos, IBlockState state, VertexBuffer tess,
protected boolean customRenderBlockToWorld(IBlockAccess world, BlockPos pos, IBlockState state, BufferBuilder tess,
TextureAtlasSprite icon, ICustomRenderer rend)
{
BaseWorldRenderTarget target = new BaseWorldRenderTarget(world, pos, tess, icon);
Expand Down
32 changes: 14 additions & 18 deletions src/base/gcewing/sg/BaseBakedRenderTarget.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,24 @@

package gcewing.sg;

import java.util.*;
import java.nio.*;
//import javax.vecmath.Vector3f;
import net.minecraft.client.renderer.block.model.*;
import net.minecraft.client.renderer.texture.TextureAtlasSprite;
import net.minecraft.client.renderer.vertex.VertexFormat;
import net.minecraft.client.renderer.vertex.VertexFormatElement;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import org.lwjgl.util.vector.Vector3f;
import net.minecraft.client.renderer.Tessellator;

import net.minecraft.block.*;
import net.minecraft.block.state.*;
import net.minecraft.client.renderer.block.model.*;
import net.minecraft.client.renderer.texture.*;
import net.minecraft.client.renderer.vertex.*;
import net.minecraft.client.renderer.block.model.*;
import net.minecraft.item.*;
import net.minecraft.util.*;
import net.minecraft.util.math.*;
import net.minecraft.world.*;
import java.nio.ByteBuffer;
import java.nio.IntBuffer;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import static net.minecraft.client.renderer.vertex.DefaultVertexFormats.*;

import net.minecraftforge.client.model.*;

import gcewing.sg.BaseModClient.ITexture;
//import javax.vecmath.Vector3f;

public class BaseBakedRenderTarget extends BaseRenderTarget {

Expand All @@ -53,7 +49,7 @@ public class BaseBakedRenderTarget extends BaseRenderTarget {
//protected VertexFormat format = Attributes.DEFAULT_BAKED_FORMAT;
//protected VertexFormat format = DefaultVertexFormats.ITEM;
protected VertexFormat format = theFormat;
protected int bytesPerVertex = format.getNextOffset();
protected int bytesPerVertex = format.getSize();
protected int intsPerVertex = bytesPerVertex / 4;
protected ByteBuffer buf = ByteBuffer.allocate(bytesPerVertex * 4);

Expand Down
23 changes: 8 additions & 15 deletions src/base/gcewing/sg/BaseBlock.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,10 @@
import net.minecraft.block.properties.*;
import net.minecraft.block.state.*;
import net.minecraft.client.particle.*;
import net.minecraft.client.renderer.texture.*;
import net.minecraft.entity.*;
import net.minecraft.entity.item.*;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.*;
import net.minecraft.item.*;
import net.minecraft.nbt.*;
import net.minecraft.tileentity.*;
import net.minecraft.util.*;
import net.minecraft.util.math.*;
Expand All @@ -30,8 +27,6 @@

import static gcewing.sg.BaseMod.*;
import static gcewing.sg.BaseModClient.*;
import static gcewing.sg.BaseUtils.*;
import static gcewing.sg.BaseBlockUtils.*;

public class BaseBlock<TE extends TileEntity>
extends BlockContainer implements BaseMod.IBlock
Expand Down Expand Up @@ -347,8 +342,7 @@ public TileEntity createNewTileEntity(World world, int meta) {
// -------------------------------------------------------------------

@Override
public IBlockState onBlockPlaced(World world, BlockPos pos, EnumFacing side,
float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer)
public IBlockState getStateForPlacement(World world, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer)
{
IBlockState state = getOrientationHandler().onBlockPlaced(this, world, pos, side,
hitX, hitY, hitZ, getStateFromMeta(meta), placer);
Expand Down Expand Up @@ -395,9 +389,9 @@ public boolean addHitEffects(IBlockState blockState, World world, RayTraceResult
int k = pos.getZ();
AxisAlignedBB boundingBox = blockState.getBoundingBox(world, pos);
float f = 0.1F;
double d0 = i + RANDOM.nextDouble() * (boundingBox.maxX - boundingBox.minX - (f * 2.0F)) + f + boundingBox.minX;
double d1 = j + RANDOM.nextDouble() * (boundingBox.maxY - boundingBox.minY - (f * 2.0F)) + f + boundingBox.minY;
double d2 = k + RANDOM.nextDouble() * (boundingBox.maxZ - boundingBox.minZ - (f * 2.0F)) + f + boundingBox.minZ;
double d0 = i + RANDOM.nextDouble() * (boundingBox.maxX - boundingBox.minX - (f * 2F)) + f + boundingBox.minX;
double d1 = j + RANDOM.nextDouble() * (boundingBox.maxY - boundingBox.minY - (f * 2F)) + f + boundingBox.minY;
double d2 = k + RANDOM.nextDouble() * (boundingBox.maxZ - boundingBox.minZ - (f * 2F)) + f + boundingBox.minZ;
switch (target.sideHit) {
case DOWN: d1 = j + boundingBox.minY - f; break;
case UP: d1 = j + boundingBox.maxY + f; break;
Expand Down Expand Up @@ -493,8 +487,8 @@ public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess world, Block
return super.getBoundingBox(state, world, pos);
}

@Override
public AxisAlignedBB getCollisionBoundingBox(IBlockState state, World world, BlockPos pos) {
// Update: This had an override above the method, may be needed.
return getBoundingBox(state, world, pos);
}

Expand All @@ -513,15 +507,15 @@ protected AxisAlignedBB getLocalBounds(IBlockAccess world, BlockPos pos, IBlockS

@Override
public void addCollisionBoxToList(IBlockState state, World world, BlockPos pos,
AxisAlignedBB clip, List result, Entity entity)
AxisAlignedBB clip, List result, Entity entity, boolean enableStats)
{
List<AxisAlignedBB> list = getGlobalCollisionBoxes(world, pos, state, entity);
if (list != null)
for (AxisAlignedBB box : list)
if (clip.intersectsWith(box))
if (clip.intersects(box))
result.add(box);
else
super.addCollisionBoxToList(state, world, pos, clip, result, entity);
super.addCollisionBoxToList(state, world, pos, clip, result, entity, enableStats);
}

protected List<AxisAlignedBB> getGlobalCollisionBoxes(IBlockAccess world, BlockPos pos,
Expand Down Expand Up @@ -550,5 +544,4 @@ protected List<AxisAlignedBB> getCollisionBoxes(IBlockAccess world, BlockPos pos
}
return null;
}

}
Loading