fix: attempt to improve test reliability. #1037
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tm91236
force-pushed
the
fix/unreliable-tests
branch
from
075a259 to
d62c4d8
Compare
The `test_jit_test` and `test_speed_comparision_test` now both use a similar test methodology, explicitly adding a fixed time delay to the jit compilation process, which will not exist in the compiled code. This makes the test intent clearer and should reduce the possibility that random timing fluctations cause unexpected test failures. refs: #1034
tm91236
force-pushed
the
fix/unreliable-tests
branch
from
d62c4d8 to
2a45cdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1034
PR Type
Description
The
test_jit_testandtest_speed_comparision_testnow both use a similar test methodology, explicitly adding a fixed time delay to the jit compilation process, which will not exist in the compiled code. This makes the test intent clearer and should reduce the possibility that random timing fluctations cause unexpected test failures.How Has This Been Tested?
Existing tests pass as expected.
Does this PR introduce a breaking change?
No
Checklist before requesting a review