Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add package-level docstrings #262

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

pc532627
Copy link
Contributor

Refs: 261

PR Type

  • Documentation content changes

Description

Package level docstrings and headers added.

How Has This Been Tested?

N/A

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@pc532627 pc532627 requested a review from tp832944 November 29, 2023 14:39
Copy link
Contributor

@tp832944 tp832944 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explains the top-level stuff nicely - thanks @pc532627. Before merging we have our outstanding discussion on terminology to resolve offline.

Please add the copyright header to tests/init.py.

examples/__init__.py Outdated Show resolved Hide resolved
@pc532627
Copy link
Contributor Author

This explains the top-level stuff nicely - thanks @pc532627. Before merging we have our outstanding discussion on terminology to resolve offline.

Please add the copyright header to tests/init.py.

I've pushed some updates to address comments, leaving the PR open until terminology discussion is resolved.

Copy link
Contributor

@tp832944 tp832944 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminology ok.

@tp832944 tp832944 merged commit d8b2cbc into feature/oop_106 Dec 6, 2023
@tp832944 tp832944 deleted the docs/add_package_docstrings_261 branch December 6, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants