Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/self hosted runner #269

Merged
merged 7 commits into from
Dec 6, 2023
Merged

Feature/self hosted runner #269

merged 7 commits into from
Dec 6, 2023

Conversation

jn177246
Copy link
Contributor

@jn177246 jn177246 commented Dec 5, 2023

PR Type

  • CI related changes

Description

The GitHub actions have been modified to run on our own self-hosted runners. The changes made are small.

How Has This Been Tested?

I modified the actions to run on commits to the feature/self_hosted_runner branch and then observed the actions complete successfully. I also checked the logs of our self-hosted runner after the action had finished.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@jn177246 jn177246 requested review from tp832944 and jd750687 and removed request for tp832944 and jd750687 December 5, 2023 15:23
Copy link
Contributor

@tp832944 tp832944 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jn177246. Works fine for me. We'll wait until @tl82649 has had a chance to test it before merging.

@tl82649 tl82649 self-requested a review December 6, 2023 12:43
Copy link
Member

@tl82649 tl82649 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and works for me too.

@tp832944 tp832944 merged commit 56c5f3e into main Dec 6, 2023
4 checks passed
@tp832944 tp832944 deleted the feature/self_hosted_runner branch December 6, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants