Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pyright benchmarking #942

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Feature/pyright benchmarking #942

merged 6 commits into from
Feb 4, 2025

Conversation

qh681248
Copy link
Contributor

#912

PR Type

  • Bugfix

Description

Static type check fixes

How Has This Been Tested?

Existing tests pass as expected.

Pyright passes on benchmark directory with 0 warnings, 0 errors and 0 informations.

Does this PR introduce a breaking change?

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@qh681248 qh681248 linked an issue Jan 30, 2025 that may be closed by this pull request
Fix static type checker complaints for benchmarking #912
Closed
@qh681248 qh681248 mentioned this pull request Jan 30, 2025
Closed
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 62fdcf8 - Merge b512f38 into cc6a510

No significant changes to performance.

@tp832944 tp832944 self-requested a review January 31, 2025 12:30
tp832944
tp832944 requested changes Jan 31, 2025
View reviewed changes
benchmark/blobs_benchmark.py Outdated Show resolved Hide resolved
benchmark/mnist_benchmark.py Outdated Show resolved Hide resolved
benchmark/mnist_benchmark.py Outdated Show resolved Hide resolved
benchmark/pounce_benchmark.py Show resolved Hide resolved
benchmark/pounce_benchmark.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 0a93416 - Merge c88b35d into 594dec1

No significant changes to performance.

@qh681248 qh681248 requested a review from tp832944 February 3, 2025 09:57
tp832944
tp832944 requested changes Feb 3, 2025
View reviewed changes
benchmark/blobs_benchmark_visualiser.py Show resolved Hide resolved
benchmark/blobs_benchmark_visualiser.py Outdated Show resolved Hide resolved
benchmark/pounce_benchmark.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Performance review

Commit 1b2ba9d - Merge e8a28a6 into bc7cf80

No significant changes to performance.

@qh681248 qh681248 requested a review from tp832944 February 4, 2025 15:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Performance review

Commit 2d85bdb - Merge 98df94b into bc7cf80

No significant changes to performance.

@tp832944 tp832944 merged commit 4767c4b into main Feb 4, 2025
20 checks passed
@tp832944 tp832944 deleted the feature/pyright_benchmarking branch February 4, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tp832944 tp832944 tp832944 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix static type checker complaints for benchmarking
2 participants
@qh681248 @tp832944