Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add package API exports in top level __all__ #949

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: add package API exports in top level __all__ #949

merged 2 commits into from
Feb 4, 2025

Conversation

gw265981
Copy link
Contributor

@gw265981 gw265981 commented Feb 3, 2025 •
edited
Loading

PR Type

  • Code style update (formatting, local variables)

Description

Closes #538.

How Has This Been Tested?

Existing tests pass as expected.

New tests introduced with this change verify that...

Does this PR introduce a breaking change?

No.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Performance review

Commit 5085848 - Merge 466f5e7 into 54a2228

No significant changes to performance.

@gw265981 gw265981 marked this pull request as ready for review February 4, 2025 13:49
@rg936672 rg936672 self-requested a review February 4, 2025 13:54
rg936672
rg936672 requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@rg936672 rg936672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "coreax/__init__.py" = ["F401"] from [tool.ruff.lint.per-file-ignores] in pyproject.toml (currently line 157).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Performance review

Commit b237515 - Merge 825b5f2 into 54a2228

No significant changes to performance.

@rg936672 rg936672 merged commit bc7cf80 into main Feb 4, 2025
20 checks passed
@rg936672 rg936672 deleted the feature/top_level_init_exports branch February 4, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rg936672 rg936672 rg936672 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Place package API exports in __all__
2 participants
@gw265981 @rg936672