Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stacklevel of MapReduce padding warning #951

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

rg936672
Copy link
Contributor

@rg936672 rg936672 commented Feb 4, 2025

PR Type

  • Bugfix

Description

MapReduce's warning about padding invariance is now raised at the correct stacklevel (so it appears at the call site, rather than in the internals of Equinox.

How Has This Been Tested?

Have checked the warning is raised at the call site.

Does this PR introduce a breaking change?

No.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@rg936672 rg936672 marked this pull request as ready for review February 4, 2025 13:35
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Performance review

Commit 012a062 - Merge 86457b6 into 54a2228

No significant changes to performance.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Performance review

Commit b94263a - Merge 9684213 into 54a2228

No significant changes to performance.

@rg936672 rg936672 self-assigned this Feb 6, 2025
@qh681248 qh681248 merged commit 94a1a2d into main Feb 7, 2025
20 checks passed
@qh681248 qh681248 deleted the fix/map-reduce-padding-warning branch February 7, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants