Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert metrics generation system tests to invoke per table #3729

Closed
patchwork01 opened this issue Nov 19, 2024 · 0 comments · Fixed by #3940
Closed

Convert metrics generation system tests to invoke per table #3729

patchwork01 opened this issue Nov 19, 2024 · 0 comments · Fixed by #3940
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Nov 19, 2024

Background

Split from:

Description

When we explicitly invoke metrics generation in system tests, we'd like to send a message per table of the current system test instead of invoking the trigger lambda.

This should allow us to run tests with an offline table, so that we can take control of the order things happen without needing to pause the whole instance.

We should be able to enable the metrics generation scheduled rule to make the tests more representative of a real system.

This should make it easier to parallelise tests in the future.

Analysis

See the parent issue for details of general code changes for schedule rules in system tests.

@patchwork01 patchwork01 modified the milestones: 0.28.0, 0.27.0 Nov 19, 2024
@patchwork01 patchwork01 modified the milestones: 0.27.0, 0.28.0, 0.29.0 Nov 19, 2024
@patchwork01 patchwork01 changed the title Enable metrics generation by default in system tests Convert metrics generation system tests to invoke per table Nov 28, 2024
@patchwork01 patchwork01 modified the milestones: 0.29.0, 0.28.0 Dec 12, 2024
@patchwork01 patchwork01 self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant