You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A system test instance is currently paused by default, so the scheduled rules never invoke partition splitting. We invoke it explicitly, but this happens for the whole instance.
Description
Instead of explicitly invoking lambdas in system tests, we'd like to enable all the schedule rules by default. In the tests when we wait for an operation that is triggered this way, we can wait for the scheduled rule to run.
This should be more representative of how the system works in reality, and it should make the tests easier to parallelise.
Analysis
We can ensure that schedule rules are enabled when we connect to an instance in DeployedSleeperInstances.createInstanceIfMissing. We can avoid ever pausing the schedule rules in any tests.
There is currently code for working with schedule rules in SnapshotsDriver. We could move that to a separate driver for schedule rules. Note that the code to disable the snapshot rule there is not currently used, so it could be deleted.
Note that all instances are deployed paused in AwsSleeperInstanceDriver.deployInstanceIfNotPresent.
We can handle this separately for each type of rule, and perform the above changes gradually:
Once all of these are finished, we can ensure we deploy an instance unpaused, and check that every scheduled rule is enabled when we connect to an instance for the first time in a test suite.
The text was updated successfully, but these errors were encountered:
Background
Split from:
A system test instance is currently paused by default, so the scheduled rules never invoke partition splitting. We invoke it explicitly, but this happens for the whole instance.
Description
Instead of explicitly invoking lambdas in system tests, we'd like to enable all the schedule rules by default. In the tests when we wait for an operation that is triggered this way, we can wait for the scheduled rule to run.
This should be more representative of how the system works in reality, and it should make the tests easier to parallelise.
Analysis
We can ensure that schedule rules are enabled when we connect to an instance in DeployedSleeperInstances.createInstanceIfMissing. We can avoid ever pausing the schedule rules in any tests.
There is currently code for working with schedule rules in SnapshotsDriver. We could move that to a separate driver for schedule rules. Note that the code to disable the snapshot rule there is not currently used, so it could be deleted.
Note that all instances are deployed paused in AwsSleeperInstanceDriver.deployInstanceIfNotPresent.
We can handle this separately for each type of rule, and perform the above changes gradually:
Once all of these are finished, we can ensure we deploy an instance unpaused, and check that every scheduled rule is enabled when we connect to an instance for the first time in a test suite.
The text was updated successfully, but these errors were encountered: