Skip to content

fix build error & handlers on disconnect #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix build error & handlers on disconnect #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a4846e
build error fixed for ios
JohnKim Aug 14, 2016
57974b7
init anyhamdler on disconnect
JohnKim Aug 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ class Socket {
}

disconnect () {
this.handlers = {};
this.onAnyHandler = null;
this.sockets.disconnect();
}

Expand Down
6 changes: 3 additions & 3 deletions ios/RNSwiftSocketIO/Socket.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class SocketIO: NSObject {
@objc func addHandlers(handlers: NSDictionary) -> Void {
for handler in handlers {
self.socket.on(handler.key as! String) { data, ack in
self.bridge.eventDispatcher.sendDeviceEventWithName(
self.bridge.eventDispatcher().sendDeviceEventWithName(
"socketEvent", body: handler.key as! String)
}
}
Expand All @@ -84,10 +84,10 @@ class SocketIO: NSObject {

private func onAnyEventHandler (sock: SocketAnyEvent) -> Void {
if let items = sock.items {
self.bridge.eventDispatcher.sendDeviceEventWithName("socketEvent",
self.bridge.eventDispatcher().sendDeviceEventWithName("socketEvent",
body: ["name": sock.event, "items": items])
} else {
self.bridge.eventDispatcher.sendDeviceEventWithName("socketEvent",
self.bridge.eventDispatcher().sendDeviceEventWithName("socketEvent",
body: ["name": sock.event])
}
}
Expand Down