Added yaml for some F425 peripherals #64
Conversation
| @@ -0,0 +1,148 @@ | |||
| "ADC?": | |||
There was a problem hiding this comment.
Please add copyright headers to this and all the other new files. You can also add yourself to the AUTHORS file if you want to.
| # RSQ0: | ||
| # RL: [0, 7] | ||
| # "RSQ?": | ||
| # "RSQ*": [0, 18] |
There was a problem hiding this comment.
Why are these lines commented out?
There was a problem hiding this comment.
I'm still trying to figure out the YAML syntax for the patches actually, commented these out as they didn't work the way that I thought they do.
| NotStarted: [0, "No regular channel conversion started"] | ||
| Started: [1, "Regular channel conversion has started"] | ||
| _write: | ||
| Clear: [0, "Clear the regular channel start flag"] |
There was a problem hiding this comment.
It looks like many of these are copied from adc_common.yaml. Please share common peripherals via includes where possible, rather than copying and pasting. See how e.g. adc_f3.yaml just includes adc_common.yaml and some other files for the parts that are different.
There was a problem hiding this comment.
Yes, it's true that many of these are common with adc_common.yaml but there are some subtle differences in the f4 series that might take a long time to compare / integrate with adc_common. So this is more of an intermediate step to have things working.
| @@ -0,0 +1,71 @@ | |||
| # Copyright 2021 The gd32-rs authors. | |||
There was a problem hiding this comment.
Will fix these 😅
| OMODE: | ||
| "OM*": | ||
| PushPull: [0, "Output push-pull (reset state)"] | ||
| OpenDrain: [1, "Output open-drain"] |
There was a problem hiding this comment.
Again, it looks like a lot of this is just copied from gpio.yaml, please include it rather than copying it. Then this file can have only the parts that are specific to the F4 family.
There was a problem hiding this comment.
Same as for the ADC, will figure out the common parts in a future commit.
I've added yaml files for some of the peripherals. Let me know if I should try to do everything before merge.