Merge pull request #42 from gd32-rust/embedded-hal-optional #156
qwandorAnnotations
9 warnings
|
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
the method `read_channel` doesn't need a mutable reference:
examples/adc.rs#L36
warning: the method `read_channel` doesn't need a mutable reference
--> examples/adc.rs:36:42
|
36 | let data: u16 = adc.read_channel(&mut ch0);
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
= note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
|
|
call to `std::mem::drop` with a value that does not implement `Drop`. Dropping such a type only extends its contained lifetimes:
src/time.rs#L247
warning: call to `std::mem::drop` with a value that does not implement `Drop`. Dropping such a type only extends its contained lifetimes
--> src/time.rs:247:9
|
247 | drop(dwt);
| ^^^^^^^^^
|
note: argument has type `gd32f1::gd32f130::DWT`
--> src/time.rs:247:14
|
247 | drop(dwt);
| ^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_non_drop
= note: `#[warn(clippy::drop_non_drop)]` on by default
|
|
this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `slice`:
src/i2c.rs#L662
warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `slice`
--> src/i2c.rs:662:42
|
662 | for (i, operation) in operations.into_iter().enumerate() {
| ^^^^^^^^^ help: call directly: `iter_mut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `#[warn(clippy::into_iter_on_ref)]` on by default
|