Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make embedded-hal 0.2.7 dependency optional #42

Merged
merged 9 commits into from
Jan 29, 2024

Update embedded-hal version in documentation.

11f30fb
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Make embedded-hal 0.2.7 dependency optional #42

Update embedded-hal version in documentation.
11f30fb
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jan 29, 2024 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check warning on line 36 in examples/adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `read_channel` doesn't need a mutable reference

warning: the method `read_channel` doesn't need a mutable reference
  --> examples/adc.rs:36:42
   |
36 |         let data: u16 = adc.read_channel(&mut ch0);
   |                                          ^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
   = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default

Check warning on line 247 in src/time.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

call to `std::mem::drop` with a value that does not implement `Drop`. Dropping such a type only extends its contained lifetimes

warning: call to `std::mem::drop` with a value that does not implement `Drop`. Dropping such a type only extends its contained lifetimes
   --> src/time.rs:247:9
    |
247 |         drop(dwt);
    |         ^^^^^^^^^
    |
note: argument has type `gd32f1::gd32f130::DWT`
   --> src/time.rs:247:14
    |
247 |         drop(dwt);
    |              ^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_non_drop
    = note: `#[warn(clippy::drop_non_drop)]` on by default

Check warning on line 662 in src/i2c.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `slice`

warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `slice`
   --> src/i2c.rs:662:42
    |
662 |         for (i, operation) in operations.into_iter().enumerate() {
    |                                          ^^^^^^^^^ help: call directly: `iter_mut`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `#[warn(clippy::into_iter_on_ref)]` on by default