Skip to content

Use u64 for tick counting in Delay implementation. #166

Use u64 for tick counting in Delay implementation.

Use u64 for tick counting in Delay implementation. #166

GitHub Actions / clippy succeeded May 16, 2024 in 0s

clippy

18 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 18
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 36 in examples/adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `read_channel` doesn't need a mutable reference

warning: the method `read_channel` doesn't need a mutable reference
  --> examples/adc.rs:36:42
   |
36 |         let data: u16 = adc.read_channel(&mut ch0);
   |                                          ^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
   = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default

Check warning on line 247 in src/time.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

call to `std::mem::drop` with a value that does not implement `Drop`. Dropping such a type only extends its contained lifetimes

warning: call to `std::mem::drop` with a value that does not implement `Drop`. Dropping such a type only extends its contained lifetimes
   --> src/time.rs:247:9
    |
247 |         drop(dwt);
    |         ^^^^^^^^^
    |
note: argument has type `cortex_m::peripheral::DWT`
   --> src/time.rs:247:14
    |
247 |         drop(dwt);
    |              ^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_non_drop
    = note: `#[warn(clippy::drop_non_drop)]` on by default

Check warning on line 171 in src/rcu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/rcu.rs:171:18
    |
171 |         unsafe { &(*RCU::ptr()).addrst() }
    |                  ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*RCU::ptr()).addrst()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 165 in src/rcu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/rcu.rs:165:18
    |
165 |         unsafe { &(*RCU::ptr()).adden() }
    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*RCU::ptr()).adden()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 144 in src/rcu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/rcu.rs:144:18
    |
144 |         unsafe { &(*RCU::ptr()).apb2rst() }
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*RCU::ptr()).apb2rst()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 139 in src/rcu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/rcu.rs:139:18
    |
139 |         unsafe { &(*RCU::ptr()).apb2en() }
    |                  ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*RCU::ptr()).apb2en()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 114 in src/rcu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/rcu.rs:114:18
    |
114 |         unsafe { &(*RCU::ptr()).apb1rst() }
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*RCU::ptr()).apb1rst()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 109 in src/rcu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/rcu.rs:109:18
    |
109 |         unsafe { &(*RCU::ptr()).apb1en() }
    |                  ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*RCU::ptr()).apb1en()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 89 in src/rcu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/rcu.rs:89:18
   |
89 |         unsafe { &(*RCU::ptr()).ahben() }
   |                  ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*RCU::ptr()).ahben()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 663 in src/i2c.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `slice`

warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `slice`
   --> src/i2c.rs:663:42
    |
663 |         for (i, operation) in operations.into_iter().enumerate() {
    |                                          ^^^^^^^^^ help: call directly: `iter_mut`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `#[warn(clippy::into_iter_on_ref)]` on by default

Check warning on line 447 in src/flash.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/flash.rs:447:18
    |
447 |         unsafe { &(*Fmc::ptr()).wp() }
    |                  ^^^^^^^^^^^^^^^^^^^ help: change this to: `(*Fmc::ptr()).wp()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 434 in src/flash.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/flash.rs:434:18
    |
434 |         unsafe { &(*Fmc::ptr()).stat() }
    |                  ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*Fmc::ptr()).stat()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 422 in src/flash.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/flash.rs:422:18
    |
422 |         unsafe { &(*Fmc::ptr()).obkey() }
    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*Fmc::ptr()).obkey()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 409 in src/flash.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/flash.rs:409:18
    |
409 |         unsafe { &(*Fmc::ptr()).obstat() }
    |                  ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*Fmc::ptr()).obstat()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 396 in src/flash.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/flash.rs:396:18
    |
396 |         unsafe { &(*Fmc::ptr()).key() }
    |                  ^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*Fmc::ptr()).key()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 384 in src/flash.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/flash.rs:384:18
    |
384 |         unsafe { &(*Fmc::ptr()).ctl() }
    |                  ^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*Fmc::ptr()).ctl()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 372 in src/flash.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/flash.rs:372:18
    |
372 |         unsafe { &(*Fmc::ptr()).addr() }
    |                  ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*Fmc::ptr()).addr()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 360 in src/flash.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/flash.rs:360:18
    |
360 |         unsafe { &(*Fmc::ptr()).ws() }
    |                  ^^^^^^^^^^^^^^^^^^^ help: change this to: `(*Fmc::ptr()).ws()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default