-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue5 upgrade dependencies d3plus #10
base: master
Are you sure you want to change the base?
Conversation
Just created an issue at d3plus for the stacked area plot problem; d3plus/d3plus#726 |
Did manage to 'fix' most of the migration/porting problems:
Just not that "stacked (chart) not working properly". Besides that I think it is acceptable as a replacement of the version with d3plusv1.9.8. The documentation and examples for are aimed at React programmers, so we might want to go that way in the future. |
Sorting problem might be fixable, tested another sorting function and on FF it remains working, just have to test Chrome. We had:
If we replace it with this
It might work on Chrome. |
The sorting problem has been fixed, so we now only have problems with the StackedArea. |
Upgrades from d3plus v1 to v2.
Related PR: #9
Related Issue: #9