Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line string feature #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

igncp
Copy link

@igncp igncp commented Feb 10, 2019

Hi,

Seems that in Bitbucket the current suffix #L does not work anymore for indicating the line number, and it requires #lines- instead. To support that, I added a new option --sourcefile-url-lines-str, maintaining backward compatibility. Has been tested and it is working.

The project is not building on install, so also applied some of the changes from: https://github.com/kolyan-r/typedoc-plugin-sourcefile-url (thanks a lot @kolyan-r !) which was discussed in an existing issue.

Not sure if this package is still maintained but would be nice to have this feature in the main package to avoid having to duplicate it locally.

Could also remove the new package-lock.json and formatting that comes with a more recent npm version.

Cheers for the plugin

@gmaggiodev
Copy link

@gdelmas can you accept the @igncp Pull Request? We need it in our project and I would like to avoid forking your work just for this.

Regards

@Naoto-Ida
Copy link

Hey I was also going to do a PR to add this feature, but found this one!
In our case, the line number is just #2 if it's on line 2.

Merging this would be much appreciated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants