Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Windows setup #238

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

Lamorak
Copy link
Contributor

@Lamorak Lamorak commented Apr 16, 2024

Summary

Allows to run desktop app on Windows

  • so far assumes hat the first serial com device is the badge because the name is not specific
  • scale of uploaded graphic is a bit off and it is grainy

How It Was Tested

manually

Copy link
Member

@mariobodemann mariobodemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, we get closer to having all OSes badge'd.

Some minor remarks, but overall looks good, and simple as an addition.

Comment on lines 11 to 14
println(it.systemPortName)
true
// return the first serial comm device, can't find it by descriptive name
// it.descriptivePortName.contains("Badger")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that this doesn't filter anything. Maybe it's a leftover debug statement?

Please remove the comments and don't print something, it feels more noisy then we need.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is mostly reason why this is still draft, the device is not called Badger on Windows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it with the best possible identifier I could find
Screenshot 2024-04-20 141305

zeapp/badge/build.gradle.kts Show resolved Hide resolved
Comment on lines +34 to +35
import de.berlindroid.zekompanion.BADGE_HEIGHT
import de.berlindroid.zekompanion.BADGE_WIDTH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if that change is needed though. Shouldn't it be included already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno, refused to build without

@mariobodemann
Copy link
Member

What do you mean with the output being grainy? Can you upload an example? (It could just be a side effect from the dithering...)

@Lamorak
Copy link
Contributor Author

Lamorak commented Apr 18, 2024

This is the result image. Of course there's dithering involved, but the text should render better. Also the scale is off
PXL_20240418_071257317

@Lamorak Lamorak marked this pull request as ready for review April 22, 2024 14:24
@milosmns
Copy link
Collaborator

milosmns commented Jul 2, 2024

@mariobodemann good to go?

@milosmns milosmns added this pull request to the merge queue Jul 3, 2024
Merged via the queue into gdg-berlin-android:main with commit d7c9ff3 Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants