-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal Windows setup #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this, we get closer to having all OSes badge'd.
Some minor remarks, but overall looks good, and simple as an addition.
println(it.systemPortName) | ||
true | ||
// return the first serial comm device, can't find it by descriptive name | ||
// it.descriptivePortName.contains("Badger") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that this doesn't filter anything. Maybe it's a leftover debug statement?
Please remove the comments and don't print something, it feels more noisy then we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is mostly reason why this is still draft, the device is not called Badger on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import de.berlindroid.zekompanion.BADGE_HEIGHT | ||
import de.berlindroid.zekompanion.BADGE_WIDTH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if that change is needed though. Shouldn't it be included already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno, refused to build without
What do you mean with the output being grainy? Can you upload an example? (It could just be a side effect from the dithering...) |
@mariobodemann good to go? |
Summary
Allows to run desktop app on Windows
How It Was Tested
manually