Skip to content
This repository was archived by the owner on Sep 25, 2019. It is now read-only.

update(server): Remove Redis, clustering. #113

Merged
merged 6 commits into from
Mar 18, 2017

Conversation

Splaktar
Copy link
Contributor

Convert session storage to Mongo.
Enable Google Edge Caching for API.
upgrade to latest Express and related libraries
convert tasks to be triggered directly instead of via Redis+Clustering
convert cron to call new tasks
remove deprecated express-annotations
remove API docs since they depended upon express-annotations
convert rate metering to in-memory only since Redis is no longer an option
temporarily disable CSRF protection

Closes #104.

…Mongo.

upgrade to latest Express and related libraries
convert tasks to be triggered directly instead of via Redis+Clustering
convert cron to call new tasks
remove deprecated express-annotations
remove API docs since they depended upon express-annotations
convert rate metering to in-memory only since Redis is no longer an option
temporarily disable CSRF protection

Fixes gdg-x#96 gdg-x#80
@Splaktar Splaktar added this to the v0.3.0 milestone Mar 17, 2017
@Splaktar
Copy link
Contributor Author

@VikramTiwari Would appreciate it if you could take a quick look at this please.

@VikramTiwari VikramTiwari self-requested a review March 18, 2017 05:19
@VikramTiwari
Copy link
Member

@Splaktar Thanks for the invitation to project. Edge cache config looks fine. My question is if it's wise to cache everything for 1 hour? I would normally cache images for about a day and no cacheing on API requests. I think this works and we should enhance on top of this moving forward.

Copy link
Member

@VikramTiwari VikramTiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Gotta say good work on API. Haven't seen this project in a long time and it felt so much evolved now.

@Splaktar
Copy link
Contributor Author

@VikramTiwari The setting in this location affects the API only. We do want to cache API requests to reduce the load on the servers and eliminate the need for running a separate Redis cluster (not cheap).

In express.js we're using etags and maxAge to do client side caching for 1 week via express.static(). I've updated the Cloud Endpoints branch to make this more clear.

it relied on `express-rate` which hasn't been updated in 5 years and depends on deprecated functions in NodeJS
we will use Cloud Endpoints for rate metering instead

Closes gdg-x#115
@Splaktar Splaktar merged commit 91d80ca into gdg-x:develop Mar 18, 2017
@Splaktar Splaktar deleted the removeRedis branch March 18, 2017 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants