Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : addHome Page and fix NavBar #8

Merged
merged 9 commits into from
Jan 17, 2024
Merged

feat : addHome Page and fix NavBar #8

merged 9 commits into from
Jan 17, 2024

Conversation

jason810496
Copy link
Member

add : Home Page

  • 完成 80%
  • TODO :
    • image slide show
    • column articles
    • RWD

fix : NavBar component

  • hover 的時候有加上底色
  • desktop 的 RWD 完成 , 可以撐到 740px 左右

- dropdown : bg-primary-700 , text-white
- hover option : bg-primary-50 , text-primary-900
- finish 80% Home Page
- scroll animation only on Home Page (use `useRouter` to get current path in `NavBar.vue`)
- RWD till 750px
@yeeway0609
Copy link
Member

照片在大螢幕會跑版,可以用div把他包起來然後隨著螢幕大小變動

@yeeway0609
Copy link
Member

yeeway0609 commented Jan 14, 2024

navbar 有這些問題:

  • 按下logo 導航到首頁
  • navbar container 最大寬度會變1270,但應該要是1200px。
  • 路由方式在github page會變成 https://gdsc-ncku.github.io/about 而不是 https://gdsc-ncku.github.io/BikeFestival17th-Frontend/about,需要跟footer一樣改用 RouterLink 導航。
  • 首頁有些字會浮現到navbar上面,所以navbar的z-index需要改到最上面

- Fix key visual image size problem
- Finish 70% RWD
- use `RouterLink` instead of `a` tag
- update router schemas
- `Home` Page :
    - `activities` section css fix
    - images src fix
- `NavBar` component : use `RouterLink` instead of `a` tag
@jason810496
Copy link
Member Author

已 Merge 目前最新 main

fix : Home Page & NavBar

  • Home Page
    • 主視覺 image 跑版
  • NavBar
    • max-x-[1200px]
    • <a> tag 改用 <RouteLink> tag
    • z-[100]

add : Home Page RWD

Home Page RWD 70% 完成

寫 RWD 幾乎都快整個重寫了 QQ

@yeeway0609
Copy link
Member

讚讚 辛苦了老哥

@yeeway0609 yeeway0609 merged commit 3d7a17c into main Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants