-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix luminescent #525
base: main
Are you sure you want to change the base?
Fix luminescent #525
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Reviewer's Guide by SourceryThis pull request updates the luminescent notebook with some improvements to the text, installation instructions, and code examples. It also updates the version number to v0.3-beta. Sequence diagram for updated simulation workflowsequenceDiagram
participant User
participant Python as Python Frontend
participant Julia as Julia Backend
participant FDTD as FDTD Solver
User->>Python: Create component with gdsfactory
Python->>Julia: make_pic_sim_prob()
Julia->>FDTD: Configure simulation
FDTD-->>Julia: Simulation setup complete
Julia->>FDTD: solve()
FDTD-->>Julia: Simulation results
Julia-->>Python: Return results
Python-->>User: Display results via load_res()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
this PR has more fixes but still doesn't work |
@joamatab Thanks I'll move the shell install script from notebook to proper place. BTW does your test server have a GPU? |
Summary by Sourcery
Update installation instructions, move material definitions, and update waveguide bend examples.
New Features:
Enhancements:
Tests: