fix debug handler and change assertions.OK() #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the exec plugin, we were writing debug output even when the user had not called `gdtcontext.WithDebug()`. In addition, stdout and stderr contents were only being written to debug writers when executed during `on.fail.exec`. These two problems are fixed in this commit in addition to correcting an erroneous `$LOCATION` in the README.md that needed to be `$$LOCATION`. Signed-off-by: Jay Pipes <[email protected]>
**BREAKING API CHANGE for plugin developers** This changes the `gdt.Assertions.OK()` interface signature to accept a `context.Context` object. This context object is required for debug output/inspection in the kube plugin. Signed-off-by: Jay Pipes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the exec plugin, we were writing debug output even when the user had
not called
gdtcontext.WithDebug(). In addition, stdout and stderrcontents were only being written to debug writers when executed during
on.fail.exec. These two problems are fixed in this commit in additionto correcting an erroneous
$LOCATIONin the README.md that needed tobe
$$LOCATION.BREAKING API CHANGE for plugin developers
This changes the
gdt.Assertions.OK()interface signature to accept acontext.Contextobject. This context object is required for debugoutput/inspection in the kube plugin.