Skip to content

Toolify #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Toolify #3

wants to merge 3 commits into from

Conversation

mortenvp
Copy link

Hi this pull-request contains two changes. Both are motivated by the need "package/bundle" the module with a different stand-alone tool (see waf build-system).

Basically waf works by creating a self-extracting binary, with all the python code it needs bundled inside.

Two things happen:

  1. All comments are stripped. This does not work with python-archive since it defines the exception classes with only a doc string. Leading to a syntax error when those doc strings are removed. Therefore I've added the pass statement.
  2. The module gets relocated, there for the absolute import does not work, and we need to do a relative import.

Hope this could be accepted :)

Thanks for a nice module - all the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant