Added a widget-based editor for YAML files #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data_yaml_editor
added 10 commits
March 22, 2024 17:55
… data_yaml_editor
tuxji
reviewed
Mar 25, 2024
tools/rack/rack.plugin/plugin.xml
Outdated
| </product> | ||
| <property name="appName" value="RITE" /> | ||
| <property name="windowImages" | ||
| value="./RITE-16.bmp,./RITE-32.bmp,./RITE-128.bmp,./RITE-256.bmp" /> |
There was a problem hiding this comment.
Not everything is an addition. This extension was deleted. Did you really want to remove the RITE image from the application splash box?
There was a problem hiding this comment.
The problem was a bad merge sometime ago that resulted in a lot of duplicate material in the plugin.xml.
The item you noted was repeated elsewhere in the file.
So I did detailed diffing and reordered some material to make it clear all the changes are additions -- and inspected them to be sure they are all additions in support of this PR. Should be good now. (and tested)
glguy
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Eric M -- added a GUI editor for yaml files, for general files and for the specific kinds used in RITE.
This is all strictly additive functionality -- a new properties page and some new menu actions.