-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a widget-based editor for YAML files #186
base: main
Are you sure you want to change the base?
Conversation
… data_yaml_editor
… data_yaml_editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only looked at the diffs (which look fine for the most part), but I don't plan to do any UI testing so I can't give a binding vote. However, I pointed out a possibly inadvertent deletion of some lines from plugin.xml.
tools/rack/rack.plugin/plugin.xml
Outdated
</product> | ||
<property name="appName" value="RITE" /> | ||
<property name="windowImages" | ||
value="./RITE-16.bmp,./RITE-32.bmp,./RITE-128.bmp,./RITE-256.bmp" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not everything is an addition. This extension was deleted. Did you really want to remove the RITE image from the application splash box?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem was a bad merge sometime ago that resulted in a lot of duplicate material in the plugin.xml.
The item you noted was repeated elsewhere in the file.
So I did detailed diffing and reordered some material to make it clear all the changes are additions -- and inspected them to be sure they are all additions in support of this PR. Should be good now. (and tested)
Per Eric M -- added a GUI editor for yaml files, for general files and for the specific kinds used in RITE.
This is all strictly additive functionality -- a new properties page and some new menu actions.