Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scrollbars to Nodegroup Store View #93

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Adding scrollbars to Nodegroup Store View #93

merged 1 commit into from
Aug 8, 2023

Conversation

davidcok
Copy link
Collaborator

@davidcok davidcok commented Aug 3, 2023

Fixes #92

To test, simply open a Nodegroup Store view that contains a typical table. Shrink and expand the view to show the vertical scrollbar and see it disappear if it is not needed.

@saratge
Copy link
Contributor

saratge commented Aug 3, 2023

Looks good Dave! When we see that in our meeting shortly, I can merge

@chrisage chrisage self-requested a review August 7, 2023 14:19
@chrisage chrisage added the enhancement New feature or request label Aug 7, 2023
@chrisage chrisage added this to the September release Sprint 1 milestone Aug 7, 2023
@baoluomeng baoluomeng requested a review from saratge August 7, 2023 14:25
@davidcok davidcok merged commit 579dd6d into main Aug 8, 2023
1 check passed
@davidcok davidcok deleted the cok-issue-92 branch August 9, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodegroup Store View needs a scrollbar
4 participants