fixes for building on windows/msys2 #1408
Conversation
giuspen
commented
Feb 2, 2025
giuspen
commented
- version locally the script geany-plugins-release.py so far hosted in the wiki
- applied fix for building without signing (missing key/certificate in the filesystem)
- applied fix to geanygendoc/docs/Makefile.am
- applied fix to lsp/src/lsp-server.c
- applied fix for languages binaries not being generated
- changed version num to 2.1
|
Could you please split each item to its own commit? We prefer having smaller more specific commits leading to the final stage. Of course each commit should be complete in regard of what it is meant to achieve, but each of these should try and be small. It also gives you the opportunity to actually explain why you changed something, both to help reviewers and future understanding of why a change has been made. |
| @@ -45,6 +45,7 @@ | |||
| # include "spawn/lspunixoutputstream.h" | |||
| #endif | |||
|
|
|||
| #include <unistd.h> | |||
There was a problem hiding this comment.
Is this change on purpose?
If so, @techee should add it upstream as well.
There was a problem hiding this comment.
No problem to add but is it actually needed @giuspen ? The plugin seemed to build without it on my machine at least.
There was a problem hiding this comment.
Hi @techee have you tried to build in msys2 or you are referring to cross compiling? I couldn't on windows/mays2 without this patch but I can revert and reapply when I build locally anyway, not a big deal
There was a problem hiding this comment.
I tried it but it's possible it was before making some changes in lsp-server.c that require this header. I was just wondering if you ran into any problems without it.
No problem to add this include and make the corresponding change in the lsp repo.
There was a problem hiding this comment.
FWIW, it's most probably because of the getpid() call, whose declaration indeed is in unistd.h.
