Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gear-program): Historical proxy implementation #196

Merged
merged 48 commits into from
Dec 5, 2024
Merged

feat(gear-program): Historical proxy implementation #196

merged 48 commits into from
Dec 5, 2024

Conversation

playX18
Copy link
Member

@playX18 playX18 commented Nov 5, 2024 •
edited by mertwole
Loading

Still Work in progress

Resolves #151
Resolves #206

@playX18 playX18 marked this pull request as ready for review November 11, 2024 08:01
gshep
gshep approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

gear-programs/historical-proxy/tests/gtest.rs Outdated Show resolved Hide resolved
gear-programs/historical-proxy/client/Cargo.toml Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/src/tests.rs Show resolved Hide resolved
gear-programs/historical-proxy/app/src/tests.rs Show resolved Hide resolved
gear-programs/historical-proxy/.gitignore Outdated Show resolved Hide resolved
@playX18 playX18 requested a review from gshep November 26, 2024 08:56
@playX18
Copy link
Member Author

playX18 commented Nov 26, 2024

At the moment this PR:

  • Introduces new program: HistoricalProxy and redirect method which is used to redirect EthToVaraEvent to correct ERC20 Relayer based on tx slot
  • ERC20 Relay is changed:
    • Removed TRANSACTIONS static, it should be up to the contract which invokes HistoricalProxy to keep track of transactions
    • Added check_proofs which receives EthToVaraEvent and returns Ok(()) if proofs are correct

Public function names (redirect, check_proofs) are not final and probably should be changed to more directly describe the purpose of them.
This PR does not yet have any changes which would break every other program in repository.

mertwole
mertwole reviewed Nov 28, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
gear-programs/historical-proxy/Cargo.toml Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/Cargo.toml Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/erc20_relay.idl Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/src/service.rs Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/src/service.rs Outdated Show resolved Hide resolved
gear-programs/historical-proxy/client/Cargo.toml Outdated Show resolved Hide resolved
gear-programs/erc20-relay/app/src/lib.rs Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/src/state.rs Outdated Show resolved Hide resolved
gear-programs/erc20-relay/app/src/service.rs Outdated Show resolved Hide resolved
mertwole
mertwole reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@mertwole mertwole left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to introduce transactions storage in vft-manager in the other PR?

@gshep gshep self-requested a review November 28, 2024 11:55
@playX18 playX18 deleted the ap/historical-proxy branch December 3, 2024 11:34
@playX18 playX18 restored the ap/historical-proxy branch December 3, 2024 11:38
@playX18 playX18 reopened this Dec 3, 2024
@playX18 playX18 requested a review from osipov-mit December 3, 2024 13:08
@mertwole mertwole removed the breaking label Dec 3, 2024
gshep
gshep reviewed Dec 4, 2024
View reviewed changes
api/gear/historical_proxy.idl Outdated Show resolved Hide resolved
api/gear/historical_proxy.idl Show resolved Hide resolved
gear-programs/erc20-relay/app/src/service.rs Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/src/service.rs Outdated Show resolved Hide resolved
gear-programs/erc20-relay/app/src/lib.rs Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/tests/gclient.rs Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/tests/gclient.rs Outdated Show resolved Hide resolved
gear-programs/historical-proxy/app/tests/shared.rs Show resolved Hide resolved
gear-programs/erc20-relay/app/src/error.rs Show resolved Hide resolved
gear-programs/historical-proxy/app/src/service.rs Outdated Show resolved Hide resolved
@gshep gshep self-requested a review December 4, 2024 08:00
@playX18 playX18 requested a review from mertwole December 4, 2024 10:31
gshep
gshep approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@mertwole mertwole removed the dontmerge label Dec 4, 2024
@playX18 playX18 merged commit 4490f2f into main Dec 5, 2024
6 checks passed
@playX18 playX18 deleted the ap/historical-proxy branch December 5, 2024 06:12
This was referenced Dec 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshep gshep gshep approved these changes

@vobradovich vobradovich Awaiting requested review from vobradovich

@osipov-mit osipov-mit Awaiting requested review from osipov-mit

@mertwole mertwole Awaiting requested review from mertwole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide vft_manager address in erc20-relay::relay Introduce historical proxy
4 participants
@playX18 @mertwole @gshep @osipov-mit