feat(relayer): Introduce KillSwitch relayer
#200
Conversation
|
Update: block finality proof history now stored in an embedded database. |
| use gear_rpc_client::GearApi; | ||
|
|
||
| impl_metered_service! { | ||
| pub(crate) struct Metrics { |
There was a problem hiding this comment.
I think it's better to duplicate metrics if they match. Anyway the names should be relayer-specific
There was a problem hiding this comment.
To not depend on Metrics in sync_authority_set_id you can query latest_observed_gear_era and latest_proven_era before calling it
| ) | ||
| } | ||
|
|
||
| pub(crate) async fn submit_proof_to_ethereum( |
There was a problem hiding this comment.
| pub(crate) async fn submit_proof_to_ethereum( | |
| pub(crate) async fn submit_merkle_root_to_ethereum( |
|
|
||
| let mut metrics = MetricsBuilder::new(); | ||
|
|
||
| let proof_storage: Box<dyn ProofStorage> = |
There was a problem hiding this comment.
maybe move to a separate fn create_proof_storage? To reuse in the merkle root relayer
| // TODO: metrics | ||
| let _metrics = metrics; |
There was a problem hiding this comment.
Don't leave TODOs - implement it or open an issue
There was a problem hiding this comment.
Sure, forgot about that
| let authority_set_hash = hex::decode(&args.genesis_config_args.authority_set_hash) | ||
| .expect("Incorrect format for authority set hash: hex-encoded hash is expected"); | ||
| let authority_set_hash = authority_set_hash | ||
| .try_into() | ||
| .expect("Incorrect format for authority set hash: wrong length"); | ||
|
|
||
| let genesis_config = GenesisConfig { | ||
| authority_set_id: args.genesis_config_args.authority_set_id, | ||
| authority_set_hash, | ||
| }; |
There was a problem hiding this comment.
This also can be reused with merkle root relayer
| genesis_config: GenesisConfig, | ||
| proof_storage: Box<dyn ProofStorage>, | ||
| from_eth_block: Option<u64>, | ||
| block_finality_storage_path: impl AsRef<Path>, |
There was a problem hiding this comment.
I think it's better to create sled::DB outside
There was a problem hiding this comment.
Why? For what purpose?
| proof_storage: Box<dyn ProofStorage>, | ||
|
|
||
| // Next eth block to process. | ||
| from_eth_block: Option<u64>, |
There was a problem hiding this comment.
it looks more like latest_eth_block
| // [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] | ||
| // ``` | ||
| // Some if we don't have the proof for block #3 or #4, we can try to get the proof for block #5. | ||
| let res = self.block_finality_storage.get_gt(key_bytes)?; |
There was a problem hiding this comment.
Actually submitting some other block will not lead to a bridge halt, so I think None should be returned
There was a problem hiding this comment.
And, ofc, this error should be reported somehow at the main_loop as it means bridge's total failure
There was a problem hiding this comment.
I'd add more metrics here such as:
- latest block (to see if relayer will be not in sync with ethereum network)
- amount of merkle roots discovered (to see if we're listening live contract)
- merkle root mismatch counter (that will display amount of merkle root mismatches found)
- latest stored finality proof (to see if relayer is not in sync with gear network)
Resolves #148 .
@reviewer-or-team