Skip to content

Commit

Permalink
State todos
Browse files Browse the repository at this point in the history
  • Loading branch information
techraed committed Nov 28, 2024
1 parent 8b40859 commit 5b7b8d1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ethexe/rpc/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

use jsonrpsee::types::ErrorObject;

// Todo [sab]
// TODO #4364: https://github.com/gear-tech/gear/issues/4364

pub fn db(err: &'static str) -> ErrorObject<'static> {
ErrorObject::owned(8000, "Database error", Some(err))
Expand Down
2 changes: 1 addition & 1 deletion ethexe/signer/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ impl Signer {
}

/// Create a ECDSA recoverable signature with pre or post EIP-155 `v` value notation.
// TODO [sab] change docs after introducing a parity
// TODO #4365
pub fn sign_digest(&self, public_key: PublicKey, digest: Digest) -> Result<Signature> {
let private_key = self.get_private_key(public_key)?;

Expand Down
4 changes: 2 additions & 2 deletions ethexe/signer/src/signature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ impl AsRef<[u8]> for RawSignature {

impl From<Signature> for RawSignature {
fn from(mut sig: Signature) -> RawSignature {
// TODO [sab]: Define parity in accordance to pre-EIP-155 and post-EIP-155 standards.
// TODO #4365: https://github.com/gear-tech/gear/issues/4365
sig.0[64] -= 27;
RawSignature(sig.0)
}
Expand Down Expand Up @@ -121,7 +121,7 @@ impl Signature {

impl From<RawSignature> for Signature {
fn from(mut sig: RawSignature) -> Self {
// TODO [sab]: Include chain id, as that's for transaction of pre-EIP-155 (!)
// TODO #4365: https://github.com/gear-tech/gear/issues/4365
sig.0[64] += 27;
Signature(sig.0)
}
Expand Down

0 comments on commit 5b7b8d1

Please sign in to comment.