Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(label): use fork-action instead of action script #3764

Merged
merged 41 commits into from
May 28, 2024
Merged

ci(label): use fork-action instead of action script #3764

merged 41 commits into from
May 28, 2024

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Feb 29, 2024 •
edited
Loading

Resolves #3661
Resolves #3821
Blocked by #3767

Migrates the action script of labeling to gear-tech/fork-action for saving the time of debugging, make the action a github repo can have these benefits

  • the action could be written in typescript
  • it can have its own CI for testing but not make our current repo more verbose and bigger
  • easier for version management

@gear-tech/dev

Test: 32a63bb

@clearloop clearloop added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed A4-insubstantial Not too important PR A5-dontmerge PR should not be merged yet labels Feb 29, 2024
@clearloop clearloop mentioned this pull request Feb 29, 2024
Closed
@clearloop clearloop mentioned this pull request Mar 19, 2024
Closed
@clearloop clearloop closed this Apr 8, 2024
@clearloop clearloop removed the A4-insubstantial Not too important PR label May 7, 2024
@clearloop clearloop reopened this May 7, 2024
@clearloop clearloop added the A4-insubstantial Not too important PR label May 7, 2024
@clearloop clearloop removed the A4-insubstantial Not too important PR label May 7, 2024
@clearloop clearloop marked this pull request as ready for review May 7, 2024 16:27
@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team E2-forcemacos Force CI to run macOS build in PR E1-forcenatwin Force CI to run native Windows build in PR and removed A0-pleasereview PR is ready to be reviewed by the team E2-forcemacos Force CI to run macOS build in PR E1-forcenatwin Force CI to run native Windows build in PR labels May 20, 2024
@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team E2-forcemacos Force CI to run macOS build in PR E1-forcenatwin Force CI to run native Windows build in PR labels May 20, 2024
@clearloop clearloop requested a review from breathx May 20, 2024 09:11
breathx
breathx approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ark0f take a look pls

good to go from my side

@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A3-gotissues PR occurred to have issues after the review labels May 26, 2024
@clearloop clearloop removed A5-dontmerge PR should not be merged yet A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes E2-forcemacos Force CI to run macOS build in PR E1-forcenatwin Force CI to run native Windows build in PR labels May 28, 2024
@clearloop clearloop added A2-mergeoncegreen PR is ready to merge after CI passes E2-forcemacos Force CI to run macOS build in PR E1-forcenatwin Force CI to run native Windows build in PR labels May 28, 2024
@clearloop
Copy link
Contributor Author

recheck everything at 0f3e90b

@clearloop clearloop merged commit 716700d into master May 28, 2024
32 checks passed
@clearloop clearloop deleted the cl/issue-3661 branch May 28, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@ark0f ark0f ark0f approved these changes

@grishasobol grishasobol Awaiting requested review from grishasobol

@StackOverflowExcept1on StackOverflowExcept1on Awaiting requested review from StackOverflowExcept1on

Assignees
No one assigned
Labels
A2-mergeoncegreen PR is ready to merge after CI passes E1-forcenatwin Force CI to run native Windows build in PR E2-forcemacos Force CI to run macOS build in PR E3-forcerelease Force CI to run release build in PR E4-forceproduction Force CI to run production build in PR
Projects
None yet
Milestone
No milestone
3 participants
@clearloop @breathx @ark0f