feat(gstd): stabilize program logs #4072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breathx
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Similar approach is used in sails for a while.
I'm super against of macros here, so if you really want such functionality to be a part of gstd, I'd go with just gstd::msg::emit/emit_bytes(..) that recalls send with 0 value and 0 destination
@DennisInSky wdyt?
|
Also there's no actually need in testing this |
|
closing this since these kind of implementations could be added to sails dynamically |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # .
Different from
gstd::debug!, developers may havelogrequirements while building programs in production, e.g. using an indexer to fetch the historical events.since our pallet haven't had an event just for program logging atm (this is also an option), the current implementation could be sending messages to another program, this PR uses
Actor::zeroas a logger program@gear-tech/dev