Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pallett-gear-voucher): Extend voucher with creation of a new program from uploaded code #4171

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

feat(pallett-gear-voucher): Extend voucher with creation of a new program from uploaded code #4171

wants to merge 25 commits into from

Conversation

vobradovich
Copy link
Member

Resolves #4170

@vobradovich vobradovich self-assigned this Aug 21, 2024
@vobradovich vobradovich added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Aug 21, 2024
@vobradovich vobradovich added A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Aug 29, 2024
@vobradovich vobradovich marked this pull request as ready for review August 29, 2024 12:26
DennisInSky
DennisInSky approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@DennisInSky DennisInSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert here, but LGTM. Maybe I would think of implementing permissions as a enum and a collection of its values as a set of voucher permissions.

breathx
breathx requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will submit proper review soon. pls dont merge

@breathx breathx added A5-dontmerge PR should not be merged yet and removed A2-mergeoncegreen PR is ready to merge after CI passes labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx requested changes

@DennisInSky DennisInSky DennisInSky approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@vobradovich vobradovich

Labels
A0-pleasereview PR is ready to be reviewed by the team A5-dontmerge PR should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend voucher with creation of a new program from uploaded code
3 participants
@vobradovich @DennisInSky @breathx