Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heuristics tests are altered to panic with multiple results #4252

Merged
merged 19 commits into from
Dec 16, 2024
Merged

Heuristics tests are altered to panic with multiple results #4252

merged 19 commits into from
Dec 16, 2024

Conversation

Lazark0x
Copy link
Member

Resolves #4246

@Lazark0x Lazark0x added the A0-pleasereview PR is ready to be reviewed by the team label Sep 24, 2024
@Lazark0x Lazark0x linked an issue Sep 24, 2024 that may be closed by this pull request
refactor(tests): Improve UX of runtime heuristics tests #4248
Closed
@Lazark0x Lazark0x requested a review from breathx September 24, 2024 10:50
@Lazark0x Lazark0x self-assigned this Oct 1, 2024
breathx
breathx reviewed Nov 4, 2024
View reviewed changes
runtime/vara/src/tests.rs Outdated Show resolved Hide resolved
@breathx breathx added the A3-gotissues PR occurred to have issues after the review label Nov 4, 2024
@breathx breathx removed the A0-pleasereview PR is ready to be reviewed by the team label Nov 5, 2024
@Lazark0x Lazark0x added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Nov 5, 2024
breathx
breathx approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Im only aware of naming for lazy pages costs, waiting for additional opinions here

runtime/vara/src/tests.rs Outdated Show resolved Hide resolved
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Dec 16, 2024
@breathx breathx merged commit 0fed2b6 into master Dec 16, 2024
12 checks passed
@breathx breathx deleted the 4248-refactor-tests-improve-ux-of-runtime-heuristics-tests branch December 16, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@StackOverflowExcept1on StackOverflowExcept1on StackOverflowExcept1on approved these changes

Assignees

@Lazark0x Lazark0x

Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(tests): Improve UX of runtime heuristics tests
3 participants
@Lazark0x @breathx @StackOverflowExcept1on