Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gear.exe): append slasher logic to middleware #4340

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

grishasobol
Copy link
Member

No description provided.

@grishasobol grishasobol self-assigned this Nov 15, 2024
@grishasobol grishasobol added the A0-pleasereview PR is ready to be reviewed by the team label Nov 15, 2024
@grishasobol
Copy link
Member Author

real diff: dn-rename-router-committed-block-fields...gsobol-symbiotic-slasher .diff: https://github.com/gear-tech/gear/compare/dn-rename-router-committed-block-fields...gsobol-symbiotic-slasher.diff

Now must be righ diff (master fully merged)

assertEq(middleware.SLASHER_FACTORY(), address(sym.slasherFactory()));
assertEq(middleware.OPERATOR_REGISTRY(), address(sym.operatorRegistry()));
assertEq(middleware.COLLATERAL(), address(wrappedVara));

sym.networkRegistry().isEntity(address(middleware));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sym.networkRegistry().isEntity(address(middleware));
assertTrue(sym.networkRegistry().isEntity(address(middleware)));

assertEq(middleware.getOperatorStakeAt(operator1, ts), 0);

// Check that operator1 is not in active operators list
(address[] memory active_operators, uint256[] memory stakes) = middleware.getActiveOperatorsStakeAt(ts);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(address[] memory active_operators, uint256[] memory stakes) = middleware.getActiveOperatorsStakeAt(ts);
(address[] memory activeOperators, uint256[] memory stakes) = middleware.getActiveOperatorsStakeAt(ts);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants