Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lazy-pages-fuzzer): Increase Wasmi's max stack size #4348

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix(lazy-pages-fuzzer): Increase Wasmi's max stack size #4348

merged 3 commits into from
Nov 22, 2024

Conversation

ByteNacked
Copy link
Member

Increase Wasmi's maximum stack size in the lazy-pages fuzzer.
This should fix failures caused by stack overflows.

@reviewer-or-team

@ByteNacked ByteNacked self-assigned this Nov 21, 2024
@ByteNacked ByteNacked added the A0-pleasereview PR is ready to be reviewed by the team label Nov 21, 2024
breathx
breathx approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I can't actually remember when we've faced fuzzer stack overflows

@ByteNacked
Copy link
Member Author

ByteNacked commented Nov 21, 2024 •
edited
Loading

But I can't actually remember when we've faced fuzzer stack overflows

We're facing them right now, check lazy-pages fuzzer alerts in tg.

@ByteNacked ByteNacked merged commit b951118 into master Nov 22, 2024
11 checks passed
@ByteNacked ByteNacked deleted the rmasl-fix-lazy-pages-fuzzer-wasmi-stack branch November 22, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@grishasobol grishasobol Awaiting requested review from grishasobol

@ukint-vs ukint-vs Awaiting requested review from ukint-vs

@ark0f ark0f Awaiting requested review from ark0f

Assignees

@ByteNacked ByteNacked

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByteNacked @breathx