Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ethexe): Skip queue reading from storage if its empty #4464

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ByteNacked
Copy link
Member

Resolves # .

@reviewer-or-team

@ByteNacked ByteNacked self-assigned this Jan 23, 2025
@ByteNacked ByteNacked added the A0-pleasereview PR is ready to be reviewed by the team label Jan 23, 2025
@ByteNacked ByteNacked changed the title feat(ethexe): Add is_queue_empty flag to ProgramState feat(ethexe): Skip queue reading from storage if its empty Jan 24, 2025
@ByteNacked
Copy link
Member Author

@grishasobol fixed your suggestion

@ByteNacked ByteNacked requested a review from ark0f January 24, 2025 07:35
@ByteNacked
Copy link
Member Author

@breathx Moved is_queue_empty flag according to your suggestion.

@ByteNacked
Copy link
Member Author

ByteNacked commented Feb 13, 2025

I think no point to do it as separate PR, also we decided to store not just empty flag but a number of messages in queue.
Will be superseded by #4488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team A5-dontmerge PR should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant