Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional step to create pgp-signed git commits #65

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

patcon
Copy link

@patcon patcon commented Feb 18, 2014

New to this myself, but seems it would be a nice addition :)

Ref: gratipay/roobot#4

To Do

  • add signed tagType to switch
  • check for gpg command and throw helpful output if unavailable
  • check for git config user.signingkey config value, with helpful output
  • pass any remaining git failures forward

@patcon
Copy link
Author

patcon commented Feb 18, 2014

This is getting handled in #66 since they're very similar

@patcon patcon closed this Feb 18, 2014
@patcon
Copy link
Author

patcon commented Feb 18, 2014

There are a few errors that can happen. We could just pass the git error forward, or we could do what is probably most of the work and check that:

  • which gpg works
  • git config user.signingkey is present

@patcon patcon reopened this Feb 18, 2014
@tomkersten
Copy link

+1
Even in current state this is a nice addition. The people who are most interested/concerned with signed releases likely will either meet the remaining requirements in the list above...or will know how to address them.

@drublic
Copy link
Collaborator

drublic commented Jan 5, 2015

This PR looks good to me. @patcon do you want to work on the other tasks you created yourself or should we merge here and we'll look into the other tasks later?

@patcon
Copy link
Author

patcon commented Jan 5, 2015

I'm not actively using grunt-release right now, so it might be awhile if you're waiting on me. 😞

In the interest of getting it in, I'd say merge and reticket anything that still needs doing :)

Thanks for the issue queue gardening btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants