-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional step to create pgp-signed git commits #65
base: master
Are you sure you want to change the base?
Conversation
This is getting handled in #66 since they're very similar |
There are a few errors that can happen. We could just pass the git error forward, or we could do what is probably most of the work and check that:
|
+1 |
This PR looks good to me. @patcon do you want to work on the other tasks you created yourself or should we merge here and we'll look into the other tasks later? |
I'm not actively using grunt-release right now, so it might be awhile if you're waiting on me. 😞 In the interest of getting it in, I'd say merge and reticket anything that still needs doing :) Thanks for the issue queue gardening btw! |
6e0c17a
to
195e82f
Compare
New to this myself, but seems it would be a nice addition :)
Ref: gratipay/roobot#4
To Do
signed
tagType to switchgpg
command and throw helpful output if unavailablegit config user.signingkey
config value, with helpful output