Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-side otsu #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

server-side otsu #13

wants to merge 1 commit into from

Conversation

Jaapel
Copy link
Collaborator

@Jaapel Jaapel commented Apr 1, 2022

I want to generate Otsu threshold server side, to make sure I can map over reservoirs server side.

@gena please check this code, I used ee.Algorithms.If to do the argument checking. I am not exactly sure how that works on the earthengine side, but I have not noticed a longer computation time.

@Jaapel Jaapel added the enhancement New feature or request label Apr 1, 2022
@Jaapel Jaapel requested a review from gena April 1, 2022 10:20
@Jaapel Jaapel self-assigned this Apr 1, 2022
Copy link
Collaborator

@gena gena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these were needed to move some argument passing server-side? Should I update the JavaScript package/ correspondingly, maybe let's quickly chat about how to keep these in sync as this is being done manually.

@Jaapel
Copy link
Collaborator Author

Jaapel commented Apr 4, 2022

I know that geemap has some conversion system converting from JavaScript. But of course, collaboration on EarthEngine code is more difficult, as it does not seem to support Pull Requests, branches etc. Let's have a chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants