Merge pull request #12 from geekcom/develop

Develop
geekcom · Dec 9, 2019 · 25eb56f · 25eb56f
2 parents be3bec5 + 007b3e2
commit 25eb56f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/.docker/Dockerfile b/.docker/Dockerfile
@@ -1,4 +1,4 @@
-FROM php:7.4-rc
+FROM php:7.4
 
 LABEL maintainer="geekcom"
 

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -2,7 +2,7 @@ version: '3'
 services:
   app:
     build: .docker
-    container_name: laika
+    container_name: felicio
     volumes:
       - .:/var/www/app
     tty: true
diff --git a/src/Felicio.php b/src/Felicio.php
@@ -4,6 +4,7 @@
 
 namespace Felicio;
 
+use Aws\Sqs\SqsClient;
 use Felicio\Contracts\FelicioContract;
 use Aws\Sdk;
 use Aws\Exception\AwsException;
@@ -13,7 +14,7 @@
 
 final class Felicio implements FelicioContract
 {
-    protected $felicioClient;
+    protected SqsClient $felicioClient;
 
     public function __construct($felicioDotFile)
     {

diff --git a/tests/FelicioTest.php b/tests/FelicioTest.php
@@ -10,7 +10,7 @@
 
 final class FelicioTest extends TestCase
 {
-    private $instance;
+    private Felicio $instance;
 
     public function setUp(): void
     {
@@ -85,8 +85,8 @@ public function deleteMessageWithoutParameters(): void
         $this->expectException(ArgumentCountError::class);
 
         $params = [
-            'QueueUrl' => '', //required
-            'ReceiptHandle' => '', //required
+            'QueueUrl' => '',
+            'ReceiptHandle' => '',
         ];
 
         $this->instance->deleteMessage($params);
@@ -97,6 +97,6 @@ public function ifExistsMessage(): void
     {
         $queueUrl = ''; //required
 
-        $this->assertGreaterThan(1, $this->instance->countMessages($queueUrl));
+        $this->assertGreaterThan(0, $this->instance->countMessages($queueUrl));
     }
 }