Skip to content

Add output buffer flushes to reduce latency #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add output buffer flushes to reduce latency #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5202b0
Add buffer flush after receiving printable char
joemcool Nov 15, 2021
94a2ef8
Added null checks for obhandle and buffer flush to shell_prompt
joemcool Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Shell.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,14 @@ void shell_task()
shellbuf[count] = rxchar;
shell_putc(rxchar);
count++;

// If we're using buffered output, flush the output buffer so the user gets immediate feedback on their key press
if (obhandle != 0) {
if (obhandle->shell_bwriter != 0)
obhandle->shell_bwriter(obhandle->outbuffer, obhandle->buffercount);
// and clear counter
obhandle->buffercount = 0;
}
}
}
// Check if a full command is available on the buffer to process
Expand Down Expand Up @@ -509,6 +517,14 @@ static void shell_prompt()
#else
shell_print((const char *) "device>");
#endif

// If we're using buffered output, flush the output buffer so the user gets immediate feedback on their key press
if (obhandle != 0) {
if (obhandle->shell_bwriter != 0)
obhandle->shell_bwriter(obhandle->outbuffer, obhandle->buffercount);
// and clear counter
obhandle->buffercount = 0;
}
}

/*-------------------------------------------------------------*
Expand Down