Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1239 - Add support for online event detection #1256

Merged
merged 3 commits into from
May 19, 2022

Conversation

lexiwitch
Copy link
Contributor

@lexiwitch lexiwitch commented May 19, 2022

Adds support for detection of online Events. Fixes #1239.

  • feat: add tests and more robustly deal with urls
  • feat: add online event detection (Add method into importers that detects if an Event is online #1239)
  • feat: add online_address_id and online_event? to base importer event
  • feat: add online address detection for eventbrite, ics, meetup, mcu
  • fix: only validate if an event is unique on creation
  • fix: make activerecord work in rake workers task

@lexiwitch lexiwitch added this to the Trans Dimension full launch milestone May 19, 2022
@lexiwitch lexiwitch requested a review from ivankocienski May 19, 2022 12:30
@lexiwitch lexiwitch self-assigned this May 19, 2022
lexiwitch added 3 commits May 19, 2022 13:34
feat: add online_address_id and online_event? to base importer event
feat: add online address detection for eventbrite, ics, meetup, mcu
fix: only validate if an event is unique on creation
fix: make activerecord work in rake workers task
- Adds testing support for ICS, Eventbrite, and Meetup event ingress
- Reverts the exception throw on event merging
- Alters ICS event regex to more robustly deal with subdomains and url
  paths
@lexiwitch lexiwitch force-pushed the 1239_online_events-pt2-electric-boogaloo branch from 69ff1ca to 8f6d1fa Compare May 19, 2022 12:40
@lexiwitch lexiwitch marked this pull request as ready for review May 19, 2022 12:40
Copy link
Contributor

@ivankocienski ivankocienski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. I assume you have tested this with production data on your local machine to see if there are any "real world" problems that pop up

@lexiwitch
Copy link
Contributor Author

Yep, everything looks fine and I was able to refine the regexes further :)
I'm waiting for a final pass after the rebase (forgot to do this lol when I marked it ready to merge) to complete but there aren't any salient problems that I can tell

@lexiwitch
Copy link
Contributor Author

Yup, it looks fine

@ivankocienski ivankocienski merged commit 61b9df2 into main May 19, 2022
@ivankocienski ivankocienski deleted the 1239_online_events-pt2-electric-boogaloo branch May 19, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method into importers that detects if an Event is online
2 participants