Refactor image preview on upload field in partner admin in stimulus #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaaaargZombies
changed the title
kimadactyl
changed the title
|
OK this is cool but not sure how it got on the backlog, it doesn't remove any behaviours files and doesn't solve an existing ticket? Only note on it is to take out the sample image for copyright reasons, maybe replace with something from unsplash.com? |
|
Apologies - I read the base ticket, so this is getting rid of part of the code. I have no memory whatsoever that we had a js handler for this, lol. So yeah just update the image and I'm happy to merge this. |
kimadactyl
changed the title
4 tasks
kimadactyl
approved these changes
Aug 9, 2022
|
confirmed working on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1421
I slightly altered the original functionality to allow for an upload preview even if no image had been uploaded before. See
app/views/admin/partners/_form.html.erbline 26. Otherwise changes are as described in the issue.