Refactor opening times picker with stimulus controller #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also now would be a good time for UI feedback |
aaaaargZombies
force-pushed
the
1417-opening-times-stimulus-controller
branch
from
8df2e86 to
1e5872e
Compare
|
Looking good! UI needs a little love obvi but great start. It currenlty looks like this for me - i think 'all day' checkbox last and get it all on one line but assume you're already on it. The 'all day' thing does create some funky states but I think it's no big deal. It should prob make it easier to add in the next day after selecting the current one too - maybe after entering a time it incremenets the day?
|
aaaaargZombies
force-pushed
the
1417-opening-times-stimulus-controller
branch
from
f83fc70 to
24e6a33
Compare
aaaaargZombies
force-pushed
the
1417-opening-times-stimulus-controller
branch
from
27c0650 to
b2e6bd0
Compare
| ]); | ||
|
|
||
| const nextDay = (day) => { | ||
| const index = |
There was a problem hiding this comment.
tip: let nextIndex = (dayOrder.indexOf(day) + 1) % dayOrder.length;
ivan-kocienski-gfsc
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a draft with the suggestion of merging this part of the work in early as it's completed.
fixes #1417
Currently doesn't fix
The last part has a lot of sprawling bits that seem to reach beyond the opening times picker and might be better approached in it's own issue/PR