Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate setup #1459

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Automate setup #1459

merged 2 commits into from
Sep 19, 2022

Conversation

erbridge
Copy link
Contributor

@erbridge erbridge commented Sep 14, 2022

  • Clarify Postgresql via Docker is optional
  • Use bin scripts for setup and updates

@kimadactyl
Copy link
Member

kimadactyl commented Sep 14, 2022

Few quick notes/qs as I log off

  • We don't use seed migration gem any more - our seeds need a total rethink how they work. It should probably be purged for now.
  • Does the js setup need to also set nvm version?
  • Importing events can take a long time - wonder if this is too much to throw into the main setup script
  • Will this update bundler and yarn every time it runs? Those messages do get annoying!
  • How is ruby version set?
  • We have a script for syncing the db from the main/staging server private notion instructions here - not sure where this should live

@ivan-kocienski-gfsc
Copy link
Contributor

Does this have a ticket associated with it? I think it is studio policy that any PR has a ticket that describes the issue.

Not that I am going to insist on it this time but I'd like to see this in future. (Or maybe I am out of line, apologies)

Copy link
Contributor

@ivan-kocienski-gfsc ivan-kocienski-gfsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me.

@erbridge
Copy link
Contributor Author

@ivan-kocienski-gfsc I think there's value in tickets when there's extended work involved in something. I think for small tech debt improvements, creating a matching ticket is overkill and process for the sake of process. Like writing a ticket for this would have taken longer than the work to fix it.

Please do tell me if you think I'm wrong about that, though.

This saves bunch of reading, copying, pasting, debugging on first setup
or when returning after a while.
@erbridge
Copy link
Contributor Author

@kimadactyl All good questions, but remember: this is just about making the already documented stuff automatic instead of needing copy-paste. There are some assumptions built in here that you've done your environment set up correctly (using RVM or rbenv, have Postgresql running, etc), that making work in a platform agnostic way would be painful. I did consider printing a bunch of "do this first" stuff to surface those requirements, but decided against it at this point.

@erbridge
Copy link
Contributor Author

Will this update bundler and yarn every time it runs?

Yes, but you only run this very infrequently. bin/setup is to be run when you first set up the project or want to restore it after being away for a while. bin/update is to be run when you pull some new changes down that might have changed some of how the project is set up.

@erbridge
Copy link
Contributor Author

Re event importing, we should take a look at the best thing to do, but probably at another time. This PR is about automating the existing set up, not innovating on it. Also the event import was pretty quick for me.

@erbridge
Copy link
Contributor Author

@kimadactyl Could you write a ticket about the database sync stuff, please? I'm not sure I have enough context to at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants