-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate setup #1459
Automate setup #1459
Conversation
erbridge
commented
Sep 14, 2022
•
edited by huly-for-github
bot
Loading
edited by huly-for-github
bot
- Clarify Postgresql via Docker is optional
- Use bin scripts for setup and updates
Few quick notes/qs as I log off
|
Does this have a ticket associated with it? I think it is studio policy that any PR has a ticket that describes the issue. Not that I am going to insist on it this time but I'd like to see this in future. (Or maybe I am out of line, apologies) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me.
@ivan-kocienski-gfsc I think there's value in tickets when there's extended work involved in something. I think for small tech debt improvements, creating a matching ticket is overkill and process for the sake of process. Like writing a ticket for this would have taken longer than the work to fix it. Please do tell me if you think I'm wrong about that, though. |
This saves bunch of reading, copying, pasting, debugging on first setup or when returning after a while.
805f6b3
to
c11b851
Compare
@kimadactyl All good questions, but remember: this is just about making the already documented stuff automatic instead of needing copy-paste. There are some assumptions built in here that you've done your environment set up correctly (using RVM or rbenv, have Postgresql running, etc), that making work in a platform agnostic way would be painful. I did consider printing a bunch of "do this first" stuff to surface those requirements, but decided against it at this point. |
Yes, but you only run this very infrequently. |
Re event importing, we should take a look at the best thing to do, but probably at another time. This PR is about automating the existing set up, not innovating on it. Also the event import was pretty quick for me. |
@kimadactyl Could you write a ticket about the database sync stuff, please? I'm not sure I have enough context to at this point. |