Test graphql image urls #1469
Test graphql image urls #1469
Conversation
For articles
In production environments the protocol should be HTTPS (which is set in the environments folder). Tests that check that the correct protocol is being used in the GQL API
There was a problem hiding this comment.
Do you think we could give PRs that fix things names and descriptions that reflect those fixes, please? I was expecting this PR to only contain some tests without any behaviour changes, and I'm not sure I follow why the behaviour has changed in the way it has to be able to review it. What was it doing before, why was that bad, and what is it doing now?
|
@erbridge The situation is this: i am working on TD tickets that relied on functionality that was broken in PC. I implemented the functionality (for the specific issue of partner logos) in #1465 which itself involved setting up PC environments. This was done and the work pushed and merged. Whilst it worked for the TD problem I was working on I couldn't figure out a way to test the functionality automatically (like as an external API user). After a weekend I thought of a way to test the GQL endpoint like an end-user would by (ab)using the system tests. This was not really the thing I was supposed to be working on (TD tickets) but I thought putting in tests was A Good Idea so I continued. The next TD ticket I got was putting images on news items. So I applied the same fix from earlier (on PC) and had gotten the system tests up to be useful. It's not a good idea at all to try to sneak extra work in but as this was the same functionality as in 1465 and this PR was already covering tests I felt that it wasn't an egregious creep of scope. |
Co-authored-by: F <[email protected]>
|
@ivan-kocienski-gfsc Failing test. |
Follows on from #1462
An expansion on the image URL feature.
Features
Tests