Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Prettier to format all Ruby code #1470

Closed
wants to merge 2 commits into from
Closed

Use Prettier to format all Ruby code #1470

wants to merge 2 commits into from

Conversation

erbridge
Copy link
Contributor

@erbridge erbridge commented Sep 28, 2022 •
edited by huly-for-github bot
Loading

We already use Prettier for many other things, so adding Ruby to the mix feels like a natural choice.

Closes #1456.

@erbridge
Use Prettier to format all Ruby code
5c2613d 
We already use Prettier for many other things, so adding Ruby to the mix
feels like a natural choice.
@erbridge erbridge mentioned this pull request Oct 4, 2022
Merged
ivan-kocienski-gfsc
ivan-kocienski-gfsc approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@ivan-kocienski-gfsc ivan-kocienski-gfsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is just formatting I think it's okay. Verified tests run locally.

@erbridge
Copy link
Contributor Author

This fights with Rubocop in a difficult to resolve way.

@erbridge erbridge closed this Oct 18, 2022
@erbridge erbridge deleted the 1456/format-ruby branch October 18, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-kocienski-gfsc ivan-kocienski-gfsc ivan-kocienski-gfsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format Ruby
2 participants
@erbridge @ivan-kocienski-gfsc