fix: Change 'domain' attribute to 'url' in Site seed #2555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimadactyl
approved these changes
Aug 13, 2024
|
Great catch thankyou! |
kimadactyl
changed the title
|
Ah ok we have this really annoying github actions issue where PRs from forked versions don't start queuing properly. I've invited you to have repo write access -- are you OK to resubmit this PR as a branch rather than from your fork? Have made a ticket for the issue (#2556) -- its not been a problem before now! Thanks for your patience. |
|
Yep, no problem - I’ll do that this afternoon. |
|
See #2560 |
auto-merge was automatically disabled
August 14, 2024 17:45
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an error that occurs when running
bin/setup.The Site seed referenced a
domainattribute that's no longer part of the DB schema. It looks likedomainwas renamed tourlin this commit, but this file wasn't updated to reflect that.