Show service area information on location lozenges #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the full neighbourhood name in neighbourhood link list
kimadactyl
requested changes
Feb 17, 2022
There was a problem hiding this comment.
- I am getting both ward and service lozenges for partners that have both (see below)
- Let's just make the tag "various" not "various areas", looks kinda janky
- This is probably a good time to add a service areas details to the partner show page? Maybe just "We operate in X, Y and Z" above the address for now?
- only show neighbourhood if no service area present - change of text when n>1 service areas `
kimadactyl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On guest users partner index page when seeing partners if the partner has a service area this now appears as a lozenge like the neighbourhood does (if present).
Things not covered in this PR: